All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Ville Nuorvala <vnuorval@tcs.hut.fi>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] IPv6: Fix erratic behavior in rt6_dump_route()
Date: Mon, 17 Nov 2003 12:43:07 -0800	[thread overview]
Message-ID: <20031117124307.660df624.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0311171155050.21177@rhea.tcs.hut.fi>

On Mon, 17 Nov 2003 12:11:52 +0200 (EET)
Ville Nuorvala <vnuorval@tcs.hut.fi> wrote:

> Hi Dave!
> 
> I noticed some erratic behavior when doing "ip -6 r". I traced the problem
> to rt6_dump_route() where we typecast NLMSG_DATA() to a rtmsg without
> checking the size of the netlink message first. Seems like ip only passes
> a rtgenmsg to the kernel when it does a dump, so we end up reading pure
> garbage when we interpret it as a rtmsg. Please apply the patch!

Thanks a lot Ville, I will review your patch a bit more and
most likely apply it later today.

  reply	other threads:[~2003-11-17 20:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-17 10:11 [PATCH] IPv6: Fix erratic behavior in rt6_dump_route() Ville Nuorvala
2003-11-17 20:43 ` David S. Miller [this message]
2003-11-18  2:50 ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031117124307.660df624.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=netdev@oss.sgi.com \
    --cc=vnuorval@tcs.hut.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.