From: 'Christoph Hellwig' <hch@infradead.org>
To: "Sachin Mhatre (smhatre)" <smhatre@cisco.com>
Cc: linux-scsi@vger.kernel.org, davmyers@cisco.com
Subject: Re: Request for review of Linux iSCSI driver version 4.0.0.1
Date: Wed, 19 Nov 2003 13:10:01 +0000 [thread overview]
Message-ID: <20031119131001.A11902@infradead.org> (raw)
In-Reply-To: <012101c3ae9d$b0a3d010$8f074d0a@apac.cisco.com>; from smhatre@cisco.com on Wed, Nov 19, 2003 at 06:34:39PM +0530
On Wed, Nov 19, 2003 at 06:34:39PM +0530, Sachin Mhatre (smhatre) wrote:
> Hi Christopher,
> Could you please elaborate on this review comment?
> - kill ctl_open/ctl_release and move add an owner to the fops
> structure for refcounting.
>
> Especially, what do you mean by "move add an owner to the fops structure
> for refcounting" ? We already use the .owner field in the
> file_operations template. What else are you refering to?
I currently do not have the code in front of me, but IIRC ctl_open/ctl_release
was only doing MOD_INC_USE_COUNT/MOD_DEC_USE_COUNT (or even a broken
equivalent). These days all refcounting is done by higher levels if you
provide a owner (=THIS_MODULE) field in struct file_operations and these
methods could be removed. If you already have the owner set that's even
easier..
next prev parent reply other threads:[~2003-11-19 13:10 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-23 12:04 Request for review of Linux iSCSI driver version 4.0.0.1 Krishna Murthy
2003-10-27 15:39 ` Christoph Hellwig
2003-10-29 13:23 ` Surekha.PC
2003-10-29 13:45 ` 'Christoph Hellwig'
2003-10-29 17:28 ` Mike Christie
2003-10-29 18:45 ` Clay Haapala
2003-10-29 19:01 ` Mike Christie
2003-10-29 19:17 ` Clay Haapala
2003-10-29 19:33 ` Mike Christie
2003-10-30 23:42 ` Andre Hedrick
2003-10-30 13:34 ` jd
2003-11-11 11:56 ` Naveen Burmi
2003-11-11 17:36 ` 'Christoph Hellwig'
2003-11-19 12:40 ` Krishna Murthy
2003-11-19 12:49 ` Matthew Wilcox
2003-11-19 13:38 ` 'Christoph Hellwig'
2003-11-11 17:40 ` James Bottomley
2003-11-06 9:42 ` Sachin Mhatre (smhatre)
2003-11-06 10:09 ` 'Christoph Hellwig'
2003-11-07 8:55 ` Douglas Gilbert
2003-11-07 9:30 ` 'Christoph Hellwig'
2003-11-10 17:43 ` Patrick Mansfield
2003-11-06 11:10 ` Andre Hedrick
2003-11-06 11:14 ` 'Christoph Hellwig'
2003-11-13 14:30 ` Sachin Mhatre (smhatre)
2003-11-13 14:54 ` Matthew Wilcox
2003-11-19 13:04 ` Sachin Mhatre (smhatre)
2003-11-19 13:10 ` 'Christoph Hellwig' [this message]
2003-11-19 14:48 ` Naveen Burmi
2003-11-19 14:48 ` Christoph Hellwig
2003-11-19 15:19 ` Naveen Burmi
2003-11-19 15:20 ` Christoph Hellwig
2003-12-01 12:10 ` Krishna Murthy
2003-12-01 15:22 ` James Bottomley
2003-12-04 12:30 ` N.C.Krishna Murthy
2003-12-05 15:33 ` James Bottomley
2003-12-05 17:03 ` Brian King
2003-12-08 15:06 ` N.C.Krishna Murthy
2003-12-08 15:46 ` Scott M. Ferris
2003-12-10 15:01 ` N.C.Krishna Murthy
2003-12-10 16:50 ` Scott M. Ferris
2003-12-11 14:48 ` N.C.Krishna Murthy
2003-12-01 15:27 ` Christoph Hellwig
2003-12-02 5:52 ` N.C.Krishna Murthy
2003-12-02 16:59 ` Patrick Mansfield
2003-11-19 17:17 ` Patrick Mansfield
2003-11-20 13:32 ` Naveen Burmi
2003-11-20 13:34 ` Christoph Hellwig
2003-11-20 14:53 ` Naveen Burmi
2003-11-22 8:16 ` How to generate ILI condtion on a tape device Kallol Biswas
2003-11-24 8:31 ` Josef Möllers
2003-11-25 7:58 ` Kallol Biswas
2003-11-21 16:42 ` Request for review of Linux iSCSI driver version 4.0.0.1 Clay Haapala
2003-11-21 17:32 ` Matthew Wilcox
2003-11-21 18:18 ` Clay Haapala
2003-11-26 13:41 ` Christoph Hellwig
2003-11-24 6:09 ` Surekha.PC
2003-11-24 7:48 ` 'Christoph Hellwig'
2003-11-24 20:45 ` Patrick Mansfield
2003-11-26 13:45 ` 'Christoph Hellwig'
2003-12-11 12:31 ` Naveen Burmi
-- strict thread matches above, loose matches on Subject: below --
2003-11-21 11:40 Shashi Kiran T.R
2003-11-21 17:56 ` Patrick Mansfield
2003-12-01 12:30 Naveen Burmi
2003-12-01 14:08 ` Naveen Burmi
2003-12-01 18:48 ` Andre Hedrick
2003-12-01 19:23 ` Andre Hedrick
2003-12-01 16:20 ` Roman Zippel
2003-12-01 17:19 ` Scott M. Ferris
2003-12-01 20:06 ` Clay Haapala
2003-12-01 20:31 ` Andre Hedrick
2003-12-01 20:58 ` Clay Haapala
2003-12-02 3:46 ` Andre Hedrick
2003-12-02 12:02 ` Naveen Burmi
2003-12-02 13:57 ` Roman Zippel
2003-12-02 11:56 ` Naveen Burmi
2003-12-02 14:11 ` Roman Zippel
2003-12-02 16:37 ` James Bottomley
2003-12-02 17:42 ` Mike Anderson
2003-12-02 23:55 ` James Bottomley
2003-12-02 23:41 ` Clay Haapala
2003-12-03 14:06 ` Naveen Burmi
2003-12-03 15:09 ` James Bottomley
2003-12-03 17:03 ` Clay Haapala
2003-12-03 17:32 ` James Bottomley
2003-12-03 17:54 ` Mike Anderson
2003-12-03 20:31 ` Clay Haapala
2003-12-03 21:14 ` James Bottomley
2003-12-03 21:53 ` Scott M. Ferris
2003-12-03 22:57 ` Scott M. Ferris
2003-12-03 20:45 ` Clay Haapala
2003-12-03 21:19 ` James Bottomley
2003-12-11 11:21 ` Naveen Burmi
2003-12-03 22:15 ` Scott M. Ferris
2003-12-03 22:32 ` Clay Haapala
2003-12-03 23:24 ` Mike Anderson
2003-12-06 19:37 ` Andre Hedrick
2003-12-07 0:37 ` Roman Zippel
2003-12-11 0:12 Pat LaVarre
2003-12-11 14:50 N.C.Krishna Murthy
2003-12-11 15:47 N.C.Krishna Murthy
2003-12-12 12:48 ` Request " Matthew Wilcox
2003-12-12 15:29 ` N.C.Krishna Murthy
2003-12-13 2:46 ` Andre Hedrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031119131001.A11902@infradead.org \
--to=hch@infradead.org \
--cc=davmyers@cisco.com \
--cc=linux-scsi@vger.kernel.org \
--cc=smhatre@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.