All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: mochel@osdl.org
Cc: linux-kernel@vger.kernel.org, wli@holomorphy.com
Subject: What keeps drivers/base/sys.c sysdev_show() from overrunning buffer?
Date: Thu, 20 Nov 2003 15:52:11 -0800	[thread overview]
Message-ID: <20031120155211.5cd2897a.pj@sgi.com> (raw)

The calls in drivers/base/sys.c to sysdev_show(), which seem to resolve
to the routines node_read_cpumap() and node_read_meminfo() in node.c,
do not take any buffer count (size).  They used to, by Patrick removed
the count parameter in Jan 2003, from here and other such places.

What's to keep the node_read_*() sprintf's from overrunning these
buffers?

I am developing some changes to the cpumask_t print routines, which
include using snprintf() instead of sprintf(), and watching buffer
limits.  These changes are motivated by the need to handle such things
as 512 CPUs.

I couldn't plug my new routine into read_cpumap() to display the
node_dev->cpumap (a cpumask_t), for want of a buffer count.

-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@sgi.com> 1.650.933.1373

             reply	other threads:[~2003-11-20 23:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-20 23:52 Paul Jackson [this message]
2003-11-21  0:03 ` What keeps drivers/base/sys.c sysdev_show() from overrunning buffer? William Lee Irwin III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031120155211.5cd2897a.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@osdl.org \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.