From: "David S. Miller" <davem@redhat.com>
To: "YOSHIFUJI Hideaki / _$B5HF#1QL@" <yoshfuji@linux-ipv6.org>
Cc: felipe_alfaro@linuxmail.org, linux-kernel@vger.kernel.org,
yoshfuji@linux-ipv6.org, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6]: IPv6: strcpy -> strlcpy
Date: Thu, 27 Nov 2003 02:59:21 -0800 [thread overview]
Message-ID: <20031127025921.3fed8dd4.davem@redhat.com> (raw)
In-Reply-To: <20031127.173320.19253188.yoshfuji@linux-ipv6.org>
On Thu, 27 Nov 2003 17:33:20 +0900 (JST)
YOSHIFUJI Hideaki / _$B5HF#1QL@ <yoshfuji@linux-ipv6.org> wrote:
> - strcpy(t->parms.name, dev->name);
> + strlcpy(t->parms.name, dev->name, IFNAMSIZ);
> sizeof(t->parms.name)
>
> or something like that.
I agree, using sizeof() is the less error prone way of
doing things like this.
Felipe could you please rewrite your patch like this?
Thank you.
next prev parent reply other threads:[~2003-11-27 11:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-27 8:14 [PATCH 2.6]: IPv6: strcpy -> strlcpy Felipe Alfaro Solana
2003-11-27 8:33 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-27 10:59 ` David S. Miller [this message]
2003-11-27 12:04 ` Felipe Alfaro Solana
2003-11-27 12:09 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-27 19:46 ` Russell King
2003-11-27 19:54 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-27 20:00 ` Russell King
2003-11-27 20:47 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-27 21:14 ` Murray J. Root
2003-11-27 22:06 ` Felipe Alfaro Solana
2003-11-27 22:19 ` Russell King
2003-11-27 22:33 ` Russell King
2003-11-28 1:34 ` Mitchell Blank Jr
2003-11-27 23:03 ` Felipe Alfaro Solana
2003-11-28 0:23 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-28 0:26 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-28 0:40 ` YOSHIFUJI Hideaki / 吉藤英明
2003-11-28 9:54 ` Felipe Alfaro Solana
2003-11-28 11:22 ` Jörn Engel
[not found] <Wt8p.1R5.13@gated-at.bofh.it>
[not found] ` <Wti7.2fc.19@gated-at.bofh.it>
[not found] ` <WAjQ.83K.37@gated-at.bofh.it>
[not found] ` <WAte.8iX.5@gated-at.bofh.it>
[not found] ` <WACW.a9.19@gated-at.bofh.it>
[not found] ` <WCuZ.2Tm.11@gated-at.bofh.it>
[not found] ` <WCOd.3u0.1@gated-at.bofh.it>
2003-11-28 14:04 ` Ihar 'Philips' Filipau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031127025921.3fed8dd4.davem@redhat.com \
--to=davem@redhat.com \
--cc=felipe_alfaro@linuxmail.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.