From: Jamie Lokier <jamie@shareable.org>
To: Nikita Danilov <Nikita@Namesys.COM>
Cc: "Joseph D. Wagner" <theman@josephdwagner.info>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
"'Matthew Wilcox'" <willy@debian.org>
Subject: Re: [PATCH] fs/locks.c fcntl_setlease did not check if a file was opened for writing before granting a read lease
Date: Thu, 27 Nov 2003 18:03:29 +0000 [thread overview]
Message-ID: <20031127180329.GC19669@mail.shareable.org> (raw)
In-Reply-To: <16326.14408.365320.326423@laputa.namesys.com>
Nikita Danilov wrote:
> > dentry->d_flags is a combination of the S_ flags, not O_ flags.
> > E.g. S_SYNC, S_NOATIME etc.
> >
> > inode->i_flags is a combination of the DCACHE_ flags.
> > E.g. DCACHE_AUTOFS_PENDING, DCACHE_REFERENCED tc.
>
> I think it is other way around. ->i_flags are combined from S_SYNC (see,
> include/linux/fs.h:IS_IMMUTABLE(), for example), and ->d_flags are
> combined from DCACHE_*, latter is explicitly stated in
> include/linux/dcache.h
Oh, yes of course :)
-- Jamie
next prev parent reply other threads:[~2003-11-27 18:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-27 16:35 [PATCH] fs/locks.c fcntl_setlease did not check if a file was opened for writing before granting a read lease Joseph D. Wagner
2003-11-27 16:50 ` Jamie Lokier
2003-11-27 17:45 ` Nikita Danilov
2003-11-27 18:03 ` Jamie Lokier [this message]
2003-11-27 8:49 ` Joseph D. Wagner
2003-11-28 1:15 ` Jamie Lokier
2003-12-02 10:53 ` Sean Neakums
2003-12-03 2:02 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031127180329.GC19669@mail.shareable.org \
--to=jamie@shareable.org \
--cc=Nikita@Namesys.COM \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=theman@josephdwagner.info \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.