All of lore.kernel.org
 help / color / mirror / Atom feed
From: hfvogt@arcor.de (Hans-Frieder Vogt)
To: lm-sensors@vger.kernel.org
Subject: [PATCH] i2c-amd8111 bug fix (compare i2c-nforce2 bug fix)
Date: Thu, 19 May 2005 06:24:27 +0000	[thread overview]
Message-ID: <200311302339.11863.hfvogt@arcor.de> (raw)

Hi,

a similar bug for the send/receive byte SMBus transfer as in the i2c-nforce2 
bus driver is also present in the i2c-amd8111 driver. The attached small 
patch corrects it. I have no board with AMD-8111 and therefore cannot test 
it, but the patch brings the AMD-8111 bus driver in line with the ACPI 2.0 
spec chapter 13.9, to which is is compliant according to the AMD-8111 data 
sheet (AMD document #24674). Can anybody with an AMD-8000 chip set based 
mainboard confirm the fix?

Hans-Frieder

--- lm_sensors2.orig/kernel/busses/i2c-amd8111.c        2003-08-03 
18:09:00.000000000 +0200
+++ lm_sensors2/kernel/busses/i2c-amd8111.c     2003-11-30 15:45:42.000000000 
+0100
@@ -198,7 +198,7 @@
 
		case I2C_SMBUS_BYTE:
 			if (read_write = I2C_SMBUS_WRITE)
-				amd_ec_write(smbus, AMD_SMB_DATA, data->byte);
+				amd_ec_write(smbus, AMD_SMB_CMD, command);
 			protocol |= AMD_SMB_PRTCL_BYTE;
 		break;


-- 
--
Hans-Frieder Vogt                 e-mail: hfvogt@arcor.de

             reply	other threads:[~2005-05-19  6:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-19  6:24 Hans-Frieder Vogt [this message]
2005-05-19  6:24 ` [PATCH] i2c-amd8111 bug fix (compare i2c-nforce2 bug fix) Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200311302339.11863.hfvogt@arcor.de \
    --to=hfvogt@arcor.de \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.