From: Alexander Viro <aviro@redhat.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Alexander Viro <aviro@redhat.com>,
Jeff Garzik <jgarzik@pobox.com>,
netdev@oss.sgi.com
Subject: Re: [PATCH] skfddi - convert to new pci model.
Date: Fri, 5 Dec 2003 18:27:21 -0500 [thread overview]
Message-ID: <20031205232721.GA24715@devserv.devel.redhat.com> (raw)
In-Reply-To: <20031205151249.44a067df.shemminger@osdl.org>
On Fri, Dec 05, 2003 at 03:12:49PM -0800, Stephen Hemminger wrote:
> Second revision of the cleanup of skfddi driver.
> * use new pci device bus initialization
> * allocate network device with alloc_fddidev
> and use dev->priv
> * get rid of special module/non module distinctions.
>
> * fix error unwinds and return values on initialization
> * call driver_init directly not via register_netdev
> * reset internal queue count after purge
> * get rid of h[iy]sterical comment that is no longer true
Looks sane.
next prev parent reply other threads:[~2003-12-05 23:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-05 0:39 [PATCH] skfddi - convert to new pci model Stephen Hemminger
2003-12-05 0:59 ` Alexander Viro
2003-12-05 23:12 ` Stephen Hemminger
2003-12-05 23:27 ` Alexander Viro [this message]
2003-12-16 5:43 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031205232721.GA24715@devserv.devel.redhat.com \
--to=aviro@redhat.com \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.