From: Chris Wright <chrisw@osdl.org>
To: netdev@oss.sgi.com
Cc: davem@redhat.com, shemminger@osdl.org
Subject: [PATCH 1/4] ax25 check error on memcpy_fromiovec
Date: Mon, 8 Dec 2003 20:23:02 -0800 [thread overview]
Message-ID: <20031208202302.C30587@build.pdx.osdl.net> (raw)
Check the return value on memcpy_fromiovec().
===== net/ax25/af_ax25.c 1.33 vs edited =====
--- 1.33/net/ax25/af_ax25.c Tue Oct 7 06:27:14 2003
+++ edited/net/ax25/af_ax25.c Fri Dec 5 16:43:44 2003
@@ -1534,7 +1534,12 @@
SOCK_DEBUG(sk, "AX.25: Appending user data\n");
/* User data follows immediately after the AX.25 data */
- memcpy_fromiovec(skb_put(skb, len), msg->msg_iov, len);
+ if (memcpy_fromiovec(skb_put(skb, len), msg->msg_iov, len)) {
+ err = -EFAULT;
+ kfree_skb(skb);
+ goto out;
+ }
+
skb->nh.raw = skb->data;
/* Add the PID if one is not supplied by the user in the skb */
next reply other threads:[~2003-12-09 4:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-09 4:23 Chris Wright [this message]
2003-12-09 4:24 ` [PATCH 2/4] irda check error on memcpy_fromiovec Chris Wright
2003-12-09 4:25 ` [PATCH 3/4] netrom " Chris Wright
2003-12-09 4:27 ` [PATCH 4/4] rose " Chris Wright
2003-12-09 5:39 ` [PATCH 1/4] ax25 " David S. Miller
2003-12-09 5:41 ` Chris Wright
2003-12-19 10:34 ` [PATCH 1/5] tun " maximilian attems
2003-12-19 14:23 ` Jeff Garzik
2004-01-17 0:45 ` Chris Wright
2004-01-21 20:49 ` Max Krasnyansky
2004-01-23 2:13 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031208202302.C30587@build.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.