From: Marco Roeland <marco.roeland@xs4all.nl>
To: Arjan van Staalduijnen <linuxkernel@bioscoopagenda.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: Compile failure when 'Preemptible Kernel' is disabled in 2.6.0-test11.
Date: Thu, 11 Dec 2003 14:33:41 +0100 [thread overview]
Message-ID: <20031211133341.GA14573@localhost> (raw)
In-Reply-To: <3FD86820.2010507@bioscoopagenda.net>
On Thursday december 11th 2003 Arjan van Staalduijnen wrote:
> [compile failure for fs/proc/array.c]
> [1.] Compile failure when 'Preemptible Kernel' is disabled.
It has nothing to do with 'preemptible'!
> [4.] Currently compiling under kernel version 'Linux version 2.6.0-test9
> (root@airraid.toptracker.com) (gcc version 2.96 20000731 (Red Hat Linux
> 7.3 2.96-113)) #1 Thu Nov 13 21:53:51 CET 2003'
This is a known compiler bug for RedHat's gcc 2.96 version. It has
difficulty casting 'unsigned long long's! Try this, it applies against
2.6.0-test8 and later.
--- linux-2.6.0-test8/fs/proc/array.c.orig 2003-10-21 16:18:40.000000000 +0200
+++ linux-2.6.0-test8/fs/proc/array.c 2003-10-23 09:30:27.000000000 +0200
@@ -302,6 +302,7 @@
pid_t ppid;
int num_threads = 0;
struct mm_struct *mm;
+ unsigned long long starttime;
state = *get_task_state(task);
vsize = eip = esp = 0;
@@ -343,9 +344,7 @@
read_lock(&tasklist_lock);
ppid = task->pid ? task->real_parent->pid : 0;
read_unlock(&tasklist_lock);
- res = sprintf(buffer,"%d (%s) %c %d %d %d %d %d %lu %lu \
-%lu %lu %lu %lu %lu %ld %ld %ld %ld %d %ld %llu %lu %ld %lu %lu %lu %lu %lu \
-%lu %lu %lu %lu %lu %lu %lu %lu %d %d %lu %lu\n",
+ res = sprintf(buffer,"%d (%s) %c %d %d %d %d %d %lu %lu ",
task->pid,
task->comm,
state,
@@ -355,7 +354,9 @@
tty_nr,
tty_pgrp,
task->flags,
- task->min_flt,
+ task->min_flt);
+ starttime = jiffies_64_to_clock_t(task->start_time - INITIAL_JIFFIES);
+ res += sprintf(buffer + res,"%lu %lu %lu %lu %lu %ld %ld %ld %ld %d %ld %llu %lu %ld %lu %lu %lu %lu %lu ",
task->cmin_flt,
task->maj_flt,
task->cmaj_flt,
@@ -367,15 +368,15 @@
nice,
num_threads,
jiffies_to_clock_t(task->it_real_value),
- (unsigned long long)
- jiffies_64_to_clock_t(task->start_time - INITIAL_JIFFIES),
+ starttime,
vsize,
mm ? mm->rss : 0, /* you might want to shift this left 3 */
task->rlim[RLIMIT_RSS].rlim_cur,
mm ? mm->start_code : 0,
mm ? mm->end_code : 0,
mm ? mm->start_stack : 0,
- esp,
+ esp);
+ res += sprintf(buffer + res,"%lu %lu %lu %lu %lu %lu %lu %lu %d %d %lu %lu\n",
eip,
/* The signal information here is obsolete.
* It must be decimal for Linux 2.0 compatibility.
next prev parent reply other threads:[~2003-12-11 13:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-11 12:50 PROBLEM: Compile failure when 'Preemptible Kernel' is disabled in 2.6.0-test11 Arjan van Staalduijnen
2003-12-11 13:33 ` Marco Roeland [this message]
2003-12-11 17:14 ` Arjan van Staalduijnen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031211133341.GA14573@localhost \
--to=marco.roeland@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxkernel@bioscoopagenda.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.