Re: [parisc-linux] proposed changes to dino.c

[Grant Grundler <grundler@parisc-linux.org>]

On Wed, Dec 10, 2003 at 04:54:24PM -0500, James Bottomley wrote:
> +/* The alignment contraints for PCI bridges under dino */
> +#define DINO_BRIDGE_ALIGN 0x100000

hrmm...I was expecting this to be defined in include/linux/pci.h
but it's not. "pbus_size_mem()" seems to take care of this
in the drivers/pci generic code.

> +		/* null out the ROM resource if there is one (we don't
> +		 * care about an expansion rom on parisc, since it
> +		 * usually contains (x86) bios code) */
> +		dev->resource[PCI_ROM_RESOURCE].flags = 0;
> +		dev->resource[PCI_ROM_RESOURCE].start = 0;
> +		dev->resource[PCI_ROM_RESOURCE].end = 0;

I just realized some drivers may need to access data (not code)
in the ROM. I'm not aware of any but I don't want to under
estimate how creative people can get. Just something to beware
when bringing up new cards.

The rest looked fine to me. I don't maintain any dino-based
machines any more and thus can't test it.

thanks,
grant