From: Adam Kropelin <akropel1@rochester.rr.com>
To: greg@kroah.com
Cc: linux-hotplug-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [PATCH] udev-009: Allow build with empty EXTRAS
Date: Tue, 16 Dec 2003 22:04:06 -0500 [thread overview]
Message-ID: <20031216220406.A23608@mail.kroptech.com> (raw)
Need to let the shell expand $EXTRAS so it can properly detect an empty
list. Without this patch, the build fails whenever $EXTRAS is empty.
--Adam
--- udev-009/Makefile Tue Dec 16 19:30:32 2003
+++ udev-009-adk/Makefile Tue Dec 16 21:47:49 2003
@@ -145,7 +145,7 @@
CFLAGS += -I$(PWD)/libsysfs
all: $(ROOT)
- @for target in $(EXTRAS) ; do \
+ @extras="$(EXTRAS)" ; for target in $$extras ; do \
echo $$target ; \
$(MAKE) prefix=$(prefix) LD="$(LD)" SYSFS="$(SYSFS)" \
-C $$target $@ ; \
@@ -223,7 +223,7 @@
| xargs rm -f
-rm -f core $(ROOT) $(GEN_HEADERS) $(GEN_CONFIGS)
$(MAKE) -C klibc clean
- @for target in $(EXTRAS) ; do \
+ @extras="$(EXTRAS)" ; for target in $$extras ; do \
echo $$target ; \
$(MAKE) prefix=$(prefix) LD="$(LD)" SYSFS="$(SYSFS)" \
-C $$target $@ ; \
@@ -286,7 +286,7 @@
$(INSTALL_DATA) udev.permissions $(DESTDIR)$(configdir)
- rm -f $(DESTDIR)$(hotplugdir)/udev.hotplug
- ln -s $(sbindir)/$(ROOT) $(DESTDIR)$(hotplugdir)/udev.hotplug
- @for target in $(EXTRAS) ; do \
+ @extras="$(EXTRAS)" ; for target in $$extras ; do \
echo $$target ; \
$(MAKE) prefix=$(prefix) LD="$(LD)" SYSFS="$(SYSFS)" \
-C $$target $@ ; \
@@ -303,7 +303,7 @@
- rmdir $(hotplugdir)
- rmdir $(configdir)
- rmdir $(udevdir)
- @for target in $(EXTRAS) ; do \
+ @extras="$(EXTRAS)" ; for target in $$extras ; do \
echo $$target ; \
$(MAKE) prefix=$(prefix) LD="$(LD)" SYSFS="$(SYSFS)" \
-C $$target $@ ; \
next reply other threads:[~2003-12-17 2:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-17 3:04 Adam Kropelin [this message]
2003-12-17 8:31 ` [PATCH] udev-009: Allow build with empty EXTRAS Greg KH
2003-12-17 16:11 ` Adam Kropelin
2003-12-17 18:34 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2003-12-17 3:04 Adam Kropelin
2003-12-17 8:31 ` Greg KH
2003-12-17 16:11 ` Adam Kropelin
2003-12-17 18:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031216220406.A23608@mail.kroptech.com \
--to=akropel1@rochester.rr.com \
--cc=greg@kroah.com \
--cc=linux-hotplug-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.