From: Adrian Bunk <bunk@fs.tum.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
linux-net@vger.kernel.org, linux-kernel@vger.kernel.org,
Rik van Riel <riel@surriel.com>,
linux-tr@linuxtr.net, jschlst@samba.org, cgoos@syskonnect.de,
mid@auk.cx, jochen@scram.de
Subject: Re: [PATCH][TRIVIAL] dep_tristate wants 3 arguments (fwd)
Date: Sun, 21 Dec 2003 03:35:45 +0100 [thread overview]
Message-ID: <20031221023545.GV12750@fs.tum.de> (raw)
In-Reply-To: <3FE2A29D.30608@pobox.com>
On Fri, Dec 19, 2003 at 02:02:53AM -0500, Jeff Garzik wrote:
> Adrian Bunk wrote:
> >
> >Consider:
> > CONFIG_TMS380TR=m
> >
> >E.g. CONFIG_TMSPCI=y shouldn't be allowed in this case.
>
>
> Remove the 'if' and you are correct :)
Agreed, the updated patch is below. :-)
> Jeff
cu
Adrian
--- linux-2.4.24-pre1-full/drivers/net/tokenring/Config.in.old 2003-12-21 03:32:12.000000000 +0100
+++ linux-2.4.24-pre1-full/drivers/net/tokenring/Config.in 2003-12-21 03:32:53.000000000 +0100
@@ -20,12 +20,12 @@
dep_tristate ' IBM Lanstreamer chipset PCI adapter support' CONFIG_IBMLS $CONFIG_TR $CONFIG_PCI
dep_tristate ' 3Com 3C359 Token Link Velocity XL adapter support' CONFIG_3C359 $CONFIG_TR $CONFIG_PCI
tristate ' Generic TMS380 Token Ring ISA/PCI adapter support' CONFIG_TMS380TR
- if [ "$CONFIG_TMS380TR" != "n" ]; then
- dep_tristate ' Generic TMS380 PCI support' CONFIG_TMSPCI $CONFIG_PCI
- dep_tristate ' Generic TMS380 ISA support' CONFIG_TMSISA $CONFIG_ISA
- dep_tristate ' Madge Smart 16/4 PCI Mk2 support' CONFIG_ABYSS $CONFIG_PCI
- dep_tristate ' Madge Smart 16/4 Ringnode MicroChannel' CONFIG_MADGEMC $CONFIG_MCA
- fi
+
+ dep_tristate ' Generic TMS380 PCI support' CONFIG_TMSPCI $CONFIG_PCI $CONFIG_TMS380TR
+ dep_tristate ' Generic TMS380 ISA support' CONFIG_TMSISA $CONFIG_ISA $CONFIG_TMS380TR
+ dep_tristate ' Madge Smart 16/4 PCI Mk2 support' CONFIG_ABYSS $CONFIG_PCI $CONFIG_TMS380TR
+ dep_tristate ' Madge Smart 16/4 Ringnode MicroChannel' CONFIG_MADGEMC $CONFIG_MCA $CONFIG_TMS380TR
+
if [ "$CONFIG_ISA" = "y" -o "$CONFIG_MCA" = "y" ]; then
tristate ' SMC ISA/MCA adapter support' CONFIG_SMCTR
fi
next prev parent reply other threads:[~2003-12-21 2:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-12 22:26 [PATCH][TRIVIAL] dep_tristate wants 3 arguments (fwd) Adrian Bunk
2003-12-12 22:34 ` Jeff Garzik
2003-12-12 22:53 ` Adrian Bunk
2003-12-19 7:02 ` Jeff Garzik
2003-12-21 2:35 ` Adrian Bunk [this message]
2003-12-21 4:17 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031221023545.GV12750@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=cgoos@syskonnect.de \
--cc=jgarzik@pobox.com \
--cc=jochen@scram.de \
--cc=jschlst@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=linux-tr@linuxtr.net \
--cc=marcelo.tosatti@cyclades.com \
--cc=mid@auk.cx \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.