From: Anton Blanchard <anton@samba.org>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] seq_file version of /proc/interrupts
Date: Tue, 23 Dec 2003 11:22:17 +1100 [thread overview]
Message-ID: <20031223002217.GC934@krispykreme> (raw)
In-Reply-To: <20031113213927.27114.qmail@lwn.net>
Hi Jon,
> Here, anyway, is a better version of the patch. It's less intrusive,
> forgoes some "cleanups" I indulged in the first time, and makes it easier
> to update other architectures. I did x86-64, ia_64 and ppc64 just for the
> heck of it, but I can't test them.
We finally got around to testing it on ppc64. Looks good, only one problem:
diff -urN -X dontdiff test9-vanilla/arch/ppc64/kernel/irq.c test9/arch/ppc64/kernel/irq.c
--- test9-vanilla/arch/ppc64/kernel/irq.c Tue Oct 21 04:40:13 2003
+++ test9/arch/ppc64/kernel/irq.c Fri Nov 14 05:10:02 2003
@@ -323,18 +323,20 @@
int show_interrupts(struct seq_file *p, void *v)
{
- int i, j;
+ int i = *(int *) v, j;
struct irqaction * action;
unsigned long flags;
That int * has to be a loff_t * or bad things will happen on a 64bit big
endian platform :)
Be nice to chuck this into -mm for some more testing.
Anton
next prev parent reply other threads:[~2003-12-23 0:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-13 17:36 [PATCH] seq_file version of /proc/interrupts Jonathan Corbet
2003-11-13 18:02 ` Jesse Barnes
2003-11-13 19:35 ` viro
2003-11-13 21:39 ` Jonathan Corbet
2003-11-13 22:26 ` Erik Jacobson
2003-11-20 16:58 ` Erik Jacobson
2003-12-23 0:22 ` Anton Blanchard [this message]
2003-12-23 0:38 ` Jonathan Corbet
2003-12-23 0:49 ` Andrew Morton
2003-12-23 1:18 ` Mike Fedyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031223002217.GC934@krispykreme \
--to=anton@samba.org \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.