From: Jens Axboe <axboe@suse.de>
To: Mark Haverkamp <markh@osdl.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Another dm and bio problem with 2.6.0
Date: Tue, 23 Dec 2003 12:45:53 +0100 [thread overview]
Message-ID: <20031223114553.GA1927@suse.de> (raw)
In-Reply-To: <1072114957.15546.23.camel@markh1.pdx.osdl.net>
On Mon, Dec 22 2003, Mark Haverkamp wrote:
> This fixes a problem similar to the patch I submitted on 11/20
>
> http://marc.theaimsgroup.com/?l=linux-kernel&m=106936439707962&w=2
>
> In this case, though, the result is an:
>
> "Incorrect number of segments after building list" message.
>
> The macro __BVEC_START assumes a bi_idx of zero when the dm code can
> submit a bio with a non-zero bi_idx.
> The code has been tested on an 8 way / 8gb OSDL STP machine with a 197G
> lvm volume running dbt2 test.
>
> ===== include/linux/bio.h 1.34 vs edited =====
> --- 1.34/include/linux/bio.h Sun Sep 21 14:50:33 2003
> +++ edited/include/linux/bio.h Wed Dec 17 07:17:53 2003
> @@ -162,7 +162,7 @@
> */
>
> #define __BVEC_END(bio) bio_iovec_idx((bio), (bio)->bi_vcnt - 1)
> -#define __BVEC_START(bio) bio_iovec_idx((bio), 0)
> +#define __BVEC_START(bio) bio_iovec_idx((bio), (bio)->bi_idx)
> #define BIOVEC_PHYS_MERGEABLE(vec1, vec2) \
> ((bvec_to_phys((vec1)) + (vec1)->bv_len) == bvec_to_phys((vec2)))
> #define BIOVEC_VIRT_MERGEABLE(vec1, vec2) \
Must have been some nasty debugging, good job. The patch is correct.
--
Jens Axboe
prev parent reply other threads:[~2003-12-23 11:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-22 17:42 [PATCH] Another dm and bio problem with 2.6.0 Mark Haverkamp
2003-12-23 11:45 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031223114553.GA1927@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.