All of lore.kernel.org
 help / color / mirror / Atom feed
From: ddkilzer@kilzer.net (David D. Kilzer)
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Michael Schmitz <schmitz@opal.biophys.uni-duesseldorf.de>,
	Jeff Garzik <jgarzik@pobox.com>,
	tulip-devel@lists.sourceforge.net,
	linuxppc-dev list <linuxppc-dev@lists.linuxppc.org>
Subject: Re: [PATCH] Fix byte-swapped ethernet addr for Asante Fast 10/100 PCI Adapter
Date: Tue, 23 Dec 2003 07:15:53 -0600	[thread overview]
Message-ID: <20031223131553.GA21005@permusion.kilzer.net> (raw)
In-Reply-To: <1072137958.705.9.camel@gaston>


On Tue, Dec 23, 2003 at 11:05:58AM +1100, Benjamin Herrenschmidt wrote:
> On Tue, 2003-12-23 at 01:27, Michael Schmitz wrote:
> > >   Original:  00:00:B5:94:71:86  [INCORRECT]
> > >    Patched:  00:00:94:B5:86:71  [CORRECT]
> > >
> > > Is it sufficient to simply check the first two bytes of the mac address
> > > to determine this?  (This is what the attached patch does.  I added a
> > > check for the first byte being 0x00 for the Asante card.)
> > >
> > > Should the first three bytes of the mac address be used intead?  (Note
> > > that I can only identify 00:A0:CC as one of the Lite-On mac addresses
> > > that would be matched by the code segment above.  I don't see a 00:C0:**
> > > entry for Lite-On in the IEEE database.)
> >
> > I'd check the first three bytes (after byte swapping :-) - there's plenty
> > of other OUIs with the leading two bytes zero.
>
> This is a card with an Open Firmware driver or not ? If it has, then
> I'd rather use the OF properties (like name property) to detect this
> specific card and flip the MAC

Please forgive my ignorance, but how do I tell if the card has an OF
driver?  Running "ofpath /dev/eth1" doesn't reveal anything, although
looking at the source for "ofpath" shows me that it doesn't handle
ethernet devices.  I don't see anything under /proc/device-tree/ that
would map to the Asante ethernet card, either.

The card does show up in "lspci" and /proc/pci (obviously).  Would
checking for the PCI vendor/device and subvendor/subdevice be
equivalent to checking for the OF name property?

Thanks!

Dave

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

  reply	other threads:[~2003-12-23 13:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-07  6:21 [PATCH] Fix byte-swapped ethernet addr for Asante Fast 10/100 PCI Adapter David D. Kilzer
2003-12-22 14:27 ` Michael Schmitz
2003-12-23  0:05   ` Benjamin Herrenschmidt
2003-12-23 13:15     ` David D. Kilzer [this message]
2003-12-23 13:26       ` Benjamin Herrenschmidt
2003-12-23 13:30       ` Michael Schmitz
2003-12-23 14:01         ` Geert Uytterhoeven
2003-12-23 14:32           ` Michael Schmitz
2003-12-23 15:06           ` David D. Kilzer
2004-01-25  1:48           ` Jeff Garzik
2004-01-25  1:48             ` Benjamin Herrenschmidt
2004-02-02  5:49               ` David D. Kilzer
2004-02-05 14:46                 ` David D. Kilzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031223131553.GA21005@permusion.kilzer.net \
    --to=ddkilzer@kilzer.net \
    --cc=benh@kernel.crashing.org \
    --cc=jgarzik@pobox.com \
    --cc=linuxppc-dev@lists.linuxppc.org \
    --cc=schmitz@opal.biophys.uni-duesseldorf.de \
    --cc=tulip-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.