From: Joe Thornber <thornber@sistina.com>
To: Christophe Saout <christophe@saout.de>
Cc: Joe Thornber <thornber@sistina.com>,
Jeff Garzik <jgarzik@pobox.com>,
Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
Fruhwirth Clemens <clemens@endorphin.org>
Subject: Re: [PATCH 2/2][RFC] Add dm-crypt target
Date: Tue, 23 Dec 2003 17:15:41 +0000 [thread overview]
Message-ID: <20031223171541.GG476@reti> (raw)
In-Reply-To: <20031223170118.GA4384@leto.cs.pocnet.net>
On Tue, Dec 23, 2003 at 06:01:18PM +0100, Christophe Saout wrote:
> So how does this look?
<snip>
> -static struct dm_daemon _kcryptd;
> +static struct dm_daemon kcryptd;
Please keep the leading underscore, it indicates that it is static
data; a convention that is used throughout dm. hch was ok about it
last time he noticed it, so he can't really complain now ;)
- Joe
next prev parent reply other threads:[~2003-12-23 17:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-22 21:42 loop driver, device-mapper and crypto Christophe Saout
2003-12-22 21:49 ` [PATCH 1/2] Add dm-daemon Christophe Saout
2003-12-23 12:27 ` Christoph Hellwig
2003-12-23 15:10 ` Joe Thornber
2003-12-22 21:52 ` [PATCH 2/2][RFC] Add dm-crypt target Christophe Saout
2003-12-22 23:07 ` Jeff Garzik
2003-12-22 23:24 ` Mike Fedyk
2003-12-22 23:29 ` Jeff Garzik
2003-12-22 23:50 ` Mike Fedyk
2003-12-23 0:10 ` Christophe Saout
2003-12-23 2:53 ` Rusty Russell
2003-12-23 13:13 ` Christoph Hellwig
2003-12-23 13:36 ` Christophe Saout
2003-12-23 15:15 ` Joe Thornber
2003-12-23 15:31 ` Jeff Garzik
2003-12-23 15:43 ` Joe Thornber
2003-12-23 17:01 ` Christophe Saout
2003-12-23 17:15 ` Joe Thornber [this message]
2003-12-23 17:14 ` Jeff Garzik
2003-12-22 22:03 ` loop driver, device-mapper and crypto Andrew Morton
2003-12-23 11:14 ` Fruhwirth Clemens
[not found] <15G6g-4oz-17@gated-at.bofh.it>
[not found] ` <15Gg9-4H6-25@gated-at.bofh.it>
2003-12-22 22:29 ` [PATCH 2/2][RFC] Add dm-crypt target Andi Kleen
2003-12-23 15:11 ` Christophe Saout
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031223171541.GG476@reti \
--to=thornber@sistina.com \
--cc=akpm@osdl.org \
--cc=christophe@saout.de \
--cc=clemens@endorphin.org \
--cc=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.