All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Ingo Molnar <mingo@elte.hu>
Cc: "David S. Miller" <davem@redhat.com>,
	linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [patch] clean up tcp_sk(), 2.6.0
Date: Tue, 30 Dec 2003 14:57:52 -0200	[thread overview]
Message-ID: <20031230165751.GH28868@conectiva.com.br> (raw)
In-Reply-To: <20031230163230.GA12553@elte.hu>

Em Tue, Dec 30, 2003 at 05:32:30PM +0100, Ingo Molnar escreveu:
> 
> i recently wasted a few hours on a bug where i used "tcp_sk(sock)"
> instead of "tcp_sk(sock->sk)" - the former, while being blatantly
> incorrect, compiles just fine on 2.6.0. The patch below is equivalent to
> the define but is also type-safe. Compiles cleanly & boots fine on
> 2.6.0.

Don't have a problem, but then it'd be nice to do this for udp_sk, raw_sk,
etc, etc :)
 
- Arnaldo

  parent reply	other threads:[~2003-12-30 16:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-30 16:32 [patch] clean up tcp_sk(), 2.6.0 Ingo Molnar
2003-12-30 16:50 ` YOSHIFUJI Hideaki / 吉藤英明
2003-12-30 16:57 ` Arnaldo Carvalho de Melo [this message]
2003-12-30 22:46 ` David S. Miller
2003-12-31 10:12   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031230165751.GH28868@conectiva.com.br \
    --to=acme@conectiva.com.br \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.