All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lennert Buytenhek <buytenh@gnu.org>
To: linux-kernel@vger.kernel.org
Cc: netdev@oss.sgi.com
Subject: [2.6.0, pktgen] divide-by-zero
Date: Wed, 31 Dec 2003 06:13:16 -0500	[thread overview]
Message-ID: <20031231111316.GA10218@gnu.org> (raw)

Hi,

When generating packets with pktgen with count=10, I get a divide-by-zero
oops in inject().

Line 273 in net/core/pktgen.c seems unsafe:
	__u64 pps = (__u32)(info->sofar * 1000) / ((__u32)(total) / 1000);

What if total < 1000 ?


cheers,
Lennert

             reply	other threads:[~2003-12-31 11:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-31 11:13 Lennert Buytenhek [this message]
2004-01-18 15:48 ` [PATCH] Re: [2.6.0, pktgen] divide-by-zero Jörn Engel
2004-01-18 19:58   ` Matthias Urlichs
2004-01-18 23:15   ` Robert Olsson
2004-01-19 17:24     ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031231111316.GA10218@gnu.org \
    --to=buytenh@gnu.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.