All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjanv@redhat.com>
To: "Justin T. Gibbs" <gibbs@scsiguy.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: aic7xxx strange code
Date: Thu, 1 Jan 2004 11:08:09 +0100	[thread overview]
Message-ID: <20040101100809.GA1053@devserv.devel.redhat.com> (raw)
In-Reply-To: <960352704.1072895786@aslan.btc.adaptec.com>

[-- Attachment #1: Type: text/plain, Size: 903 bytes --]

On Wed, Dec 31, 2003 at 11:36:26AM -0700, Justin T. Gibbs wrote:
> > consistent memory ALWAYS comes from lower 4Gb regardless of the
> > pci_set_dma_mask() setting;
> 
> This isn't true on some architectures in the 2.4 kernel.  Look at, for
> example, arch/ia64/hp/common/sba_iommu.c in the RedHat 2.4.18-e.31 kernel.
> This is why this particular hack was added.

Thank you for reporting this very serious bug in our kernel; we will fix it
as soon as possible.

> I'm more than happy to change the #ifdefs on the hack to exclude 2.6
> so long as all platforms the driver operates under behave as expected.
> If 2.4 is any guide, however, there may still be some bogus code lurking
> around that uses the "normal" dma mask incorrectly.

Those platforms break the API and should be fixed as opposed to hacks added
to every single driver in drivers/*

Greetings,
    Arjan van de Ven

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2004-01-01 10:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-31 15:46 aic7xxx strange code Arjan van de Ven
2003-12-31 18:36 ` Justin T. Gibbs
2004-01-01 10:08   ` Arjan van de Ven [this message]
2004-01-01 16:16     ` Justin T. Gibbs
2004-01-01 16:17       ` Arjan van de Ven
2004-01-01 16:21         ` Justin T. Gibbs
2004-01-01 16:28           ` Arjan van de Ven
2004-01-01 22:31             ` Andi Kleen
2004-01-01 22:34               ` Arjan van de Ven
2004-01-01 23:14                 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040101100809.GA1053@devserv.devel.redhat.com \
    --to=arjanv@redhat.com \
    --cc=gibbs@scsiguy.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.