From: William Lee Irwin III <wli@holomorphy.com>
To: Michel D?nzer <michel@daenzer.net>
Cc: Arjan van de Ven <arjanv@redhat.com>,
Jon Smirl <jonsmirl@yahoo.com>,
dri-devel <dri-devel@lists.sourceforge.net>,
linux-kernel@vger.kernel.org
Subject: Re: [Dri-devel] 2.6 kernel change in nopage
Date: Thu, 1 Jan 2004 07:06:53 -0800 [thread overview]
Message-ID: <20040101150653.GC3242@holomorphy.com> (raw)
In-Reply-To: <1072967278.1603.270.camel@thor.asgaard.local>
On Thu, Jan 01, 2004 at 03:27:59PM +0100, Michel D?nzer wrote:
> Does this look better? Maybe a macro (or a typedef?) for the type of the
> last argument would still be a good idea? Or is there yet a better way?
I'm going to regret suggesting this, but how about:
(a) a typedef for the arg itself
(b) a macro and/or inline for the type update
both simultaneously?
So we'd have centralized in one place:
#if /* kernel version > 2.6.0 */
typdef int *third_arg_t;
#define third_arg_update(type) do { *(type) = VM_FAULT_MINOR; } while (0)
#else
typdef int third_arg_t;
#define third_arg_update(type) do { } while (0)
#endif
... and the natural usage that follows.
-- wli
next prev parent reply other threads:[~2004-01-01 15:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20031231182148.26486.qmail@web14918.mail.yahoo.com>
2004-01-01 12:03 ` [Dri-devel] 2.6 kernel change in nopage Michel Dänzer
2004-01-01 12:10 ` Arjan van de Ven
2004-01-01 12:23 ` Michel Dänzer
2004-01-01 12:28 ` Arjan van de Ven
2004-01-01 14:27 ` Michel Dänzer
2004-01-01 15:06 ` William Lee Irwin III [this message]
2004-01-01 20:19 ` Linus Torvalds
2004-01-01 20:57 ` Nigel Cunningham
2004-01-01 22:57 ` Linus Torvalds
2004-01-10 21:54 ` Michel Dänzer
2004-01-10 22:08 ` Arjan van de Ven
2004-01-11 0:15 ` Michel Dänzer
2004-01-01 13:33 ` William Lee Irwin III
2004-01-01 13:50 ` Michel Dänzer
2004-01-01 14:13 ` William Lee Irwin III
2004-01-01 17:55 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040101150653.GC3242@holomorphy.com \
--to=wli@holomorphy.com \
--cc=arjanv@redhat.com \
--cc=dri-devel@lists.sourceforge.net \
--cc=jonsmirl@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.