From: Jens Axboe <axboe@suse.de>
To: Christophe Saout <christophe@saout.de>
Cc: Linux-Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [RFC][PATCH] Move bv_offset/bv_len update after bio_endio in __end_that_request_first
Date: Fri, 2 Jan 2004 14:56:45 +0100 [thread overview]
Message-ID: <20040102135645.GA20572@suse.de> (raw)
In-Reply-To: <1073048438.4239.10.camel@leto.cs.pocnet.net>
On Fri, Jan 02 2004, Christophe Saout wrote:
> Am Fr, den 02.01.2004 schrieb Jens Axboe um 11:46:
>
> > > That's why I need to know exactly how many and which bvecs were completed
> > > in my bi_end_io function.
> > >
> > > Or do you think it is safer to count backwards using bi_vcnt and bi_size?
> >
> > I'm inclined to thinking that, indeed. Those two fields have a more well
> > established usage, so I think you'll be better off doing that in the
> > long run.
>
> Ok, if you say so. This and the IDE multwrite thing are the only two
> places in the kernel preventing bi_idx to be usable this way. I just
> thought it was nicer.
It is nicer, I agree. I'm not adverse to including the ll_rw_blk change,
you'll have to deal with IDE yourself :)
--
Jens Axboe
prev parent reply other threads:[~2004-01-02 13:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-01 17:32 [RFC][PATCH] Move bv_offset/bv_len update after bio_endio in __end_that_request_first Christophe Saout
2004-01-02 10:46 ` Jens Axboe
2004-01-02 13:00 ` Christophe Saout
2004-01-02 13:26 ` Christophe Saout
2004-01-02 13:56 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040102135645.GA20572@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=christophe@saout.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.