All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan-Benedict Glaw <jbglaw@lug-owl.de>
To: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] 2.6.0 aic7xxx and aic79xx stale pci_device list entry
Date: Sat, 3 Jan 2004 14:59:06 +0100	[thread overview]
Message-ID: <20040103135906.GE14285@lug-owl.de> (raw)
In-Reply-To: <1073128375.5478.12.camel@opiate>

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]

On Sat, 2004-01-03 06:12:56 -0500, Eric Kerin <eric@bootseg.com>
wrote in message <1073128375.5478.12.camel@opiate>:
> On Sat, 2004-01-03 at 04:01, Arjan van de Ven wrote: 
> > On Fri, 2004-01-02 at 21:50, Eric Kerin wrote:
> --- aic7xxx_osm.c.original	2004-01-02 03:56:32.000000000 -0500
> +++ aic7xxx_osm.c	2004-01-03 05:03:41.000000000 -0500
> @@ -913,6 +915,10 @@ ahc_linux_detect(Scsi_Host_Template *tem
>  	spin_lock_irq(&io_request_lock);
>  #endif
>  	aic7xxx_detect_complete++;
> +	if(pci_reg_state == 0 && found == 0){
> +		return(1); 
                ^^^^^^^^^^
> +	}
> +
>  	return (found);
        ^^^^^^^^^^^^^^^
>  }

Please, don't. "return" isn't a function, so please omit braces around
the return value. Just remove those braces from the not-touched "return"
statement...

MfG, JBG

-- 
   Jan-Benedict Glaw       jbglaw@lug-owl.de    . +49-172-7608481
   "Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg
    fuer einen Freien Staat voll Freier Bürger" | im Internet! |   im Irak!
   ret = do_actions((curr | FREE_SPEECH) & ~(NEW_COPYRIGHT_LAW | DRM | TCPA));

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2004-01-03 13:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-02 20:50 [PATCH] 2.6.0 aic7xxx and aic79xx stale pci_device list entry Eric Kerin
2004-01-03  9:01 ` Arjan van de Ven
2004-01-03 11:12   ` Eric Kerin
2004-01-03 13:59     ` Jan-Benedict Glaw [this message]
2004-01-24 16:09     ` Eric Kerin
2004-01-03 22:24   ` Justin T. Gibbs
2004-01-04 10:04     ` Arjan van de Ven
2004-01-30  5:25       ` Justin T. Gibbs
2004-01-30 14:41         ` Arjan van de Ven
2004-01-30 15:03           ` Justin T. Gibbs
2004-01-03 22:24 ` Justin T. Gibbs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040103135906.GE14285@lug-owl.de \
    --to=jbglaw@lug-owl.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.