All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eugene Teo <eugene.teo@eugeneteo.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] Check return value in mm/memory.c
Date: Sun, 04 Jan 2004 03:32:45 +0000	[thread overview]
Message-ID: <20040104033245.GD20458@eugeneteo.net> (raw)
In-Reply-To: <20040103132946.GE21909@eugeneteo.net>

<quote sender="Matthew Wilcox">
> On Sat, Jan 03, 2004 at 09:29:46PM +0800, Eugene Teo wrote:
> > http://www.anomalistic.org/patches/memory-check-ret-find_extend_vma-fix-2.6.1-rc1-mm1.patch
> > 
> > diff -Naur -X /home/amnesia/w/dontdiff 2.6.1-rc1-mm1/mm/memory.c 2.6.1-rc1-mm1-fix/mm/memory.c
> > --- 2.6.1-rc1-mm1/mm/memory.c	2004-01-03 20:33:39.000000000 +0800
> > +++ 2.6.1-rc1-mm1-fix/mm/memory.c	2004-01-03 20:50:13.000000000 +0800
> > @@ -34,6 +34,9 @@
> >   *
> >   * 16.07.99  -  Support of BIGMEM added by Gerhard Wichert, Siemens AG
> >   *		(Gerhard.Wichert@pdb.siemens.de)
> > + *
> > + * 03.01.04  -	Check the return value of find_extend_vma, added by
> > + * 		Eugene Teo (eugeneteo@eugeneteo.net)
> >   */
> >  
> >  #include <linux/kernel_stat.h>
> > @@ -712,6 +715,8 @@
> >  		struct vm_area_struct *	vma;
> >  
> >  		vma = find_extend_vma(mm, start);
> > +		if (unlikely(!vma))
> > +			return -EFAULT;
> 
> But we already check the return value ...
> 
>                 vma = find_extend_vma(mm, start);
> 
> #ifdef FIXADDR_USER_START
>                 if (!vma &&
>                     start >= FIXADDR_USER_START && start < FIXADDR_USER_END) {
> ...
> #endif
> 
>                 if (!vma || (pages && (vma->vm_flags & VM_IO))
>                                 || !(flags & vma->vm_flags))
>                         return i ? : -EFAULT;

Whoops. Thanks Matthew.

-- 
Eugene TEO   <eugeneteo@eugeneteo.net>   <http://www.anomalistic.org/>
1024D/14A0DDE5 print D851 4574 E357 469C D308  A01E 7321 A38A 14A0 DDE5
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2004-01-04  3:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-03 13:29 [Kernel-janitors] [PATCH] Check return value in mm/memory.c Eugene Teo
2004-01-03 13:30 ` [Kernel-janitors] [PATCH] Check return value in Eugene Teo
2004-01-03 13:31 ` [Kernel-janitors] [PATCH] Check return value in net/ipv4/ipmr.c Eugene Teo
2004-01-03 13:31 ` [Kernel-janitors] [PATCH] Check return value in fs/cifs/file.c Eugene Teo
2004-01-03 22:31 ` [Kernel-janitors] [PATCH] Check return value in mm/memory.c Matthew Wilcox
2004-01-03 22:35 ` [Kernel-janitors] [PATCH] Check return value in Matthew Wilcox
2004-01-03 22:37 ` [Kernel-janitors] [PATCH] Check return value in net/ipv4/ipmr.c Matthew Wilcox
2004-01-04  2:39 ` [Kernel-janitors] [PATCH] Check return value in Eugene Teo
2004-01-04  2:45 ` [Kernel-janitors] [PATCH] Check return value in net/ipv4/ipmr.c Eugene Teo
2004-01-04  3:32 ` Eugene Teo [this message]
2004-01-04  7:58 ` [Kernel-janitors] [PATCH] Check return value in Eugene Teo
2004-01-04  8:07 ` Eugene Teo
2004-01-04  8:25 ` [Kernel-janitors] [PATCH] Check return value of __copy_from_user Eugene Teo
2004-01-04  8:47 ` [Kernel-janitors] [PATCH] Check return value of kernel_thread Eugene Teo
2004-01-08  0:45 ` [Kernel-janitors] [PATCH] Check return value in Randy.Dunlap
2004-01-08 12:18 ` Eugene Teo
2004-01-09  0:25 ` [Kernel-janitors] [PATCH] Check return value of __copy_from_user Randy.Dunlap
2004-01-09  0:54 ` Eugene Teo
2004-01-09  1:17 ` Eugene Teo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040104033245.GD20458@eugeneteo.net \
    --to=eugene.teo@eugeneteo.net \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.