From: Jens Axboe <axboe@suse.de>
To: Peter Chubb <peter@chubb.wattle.id.au>
Cc: Hugang <hugang@soulinfo.com>, Bart Samwel <bart@samwel.tk>,
Andrew Morton <akpm@osdl.org>,
smackinlay@mail.com, Bartek Kania <mrbk@gnarf.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] laptop-mode-2.6.0 version 5
Date: Sun, 4 Jan 2004 11:31:19 +0100 [thread overview]
Message-ID: <20040104103119.GB3418@suse.de> (raw)
In-Reply-To: <16375.57972.132841.32878@wombat.chubb.wattle.id.au>
On Sun, Jan 04 2004, Peter Chubb wrote:
> >>>>> "Jens" == Jens Axboe <axboe@suse.de> writes:
>
> Jens> The dump printk() needs to be changed anyways, the rw
> Jens> deciphering is not correct. Something like this is more
> Jens> appropriate:
>
> Jens> if (unlikely(block_dump)) {
> Jens> char b[BDEVNAME_SIZE];
> Jens> printk("%s(%d): %s block %Lu on %s\n", current->comm, current-> pid, (rw & WRITE) ? "WRITE" : "READ",
> Jens> (u64) bio->bi_sector, bdevname(bio->bi_bdev, b));
> Jens> }
>
> Please cast to (unsigned long long) not (u64) because on 64-bit
> architectures u64 is unsigned long, and you'll get a compiler warning.
Yeah Andrew noted the same thing, my bad.
--
Jens Axboe
next prev parent reply other threads:[~2004-01-04 10:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20031231210756.315.qmail@mail.com>
[not found] ` <3FF3887C.90404@samwel.tk>
[not found] ` <20031231184830.1168b8ff.akpm@osdl.org>
[not found] ` <3FF43BAF.7040704@samwel.tk>
[not found] ` <3FF457C0.2040303@samwel.tk>
[not found] ` <20040101183545.GD5523@suse.de>
2004-01-02 9:02 ` [PATCH] laptop-mode-2.6.0 version 5 Hugang
2004-01-02 11:27 ` Jens Axboe
2004-01-02 11:38 ` Hugang
2004-01-02 12:03 ` Jens Axboe
2004-01-04 9:52 ` Peter Chubb
2004-01-04 10:31 ` Jens Axboe [this message]
2004-03-29 15:42 ` Jens Axboe
2004-03-29 15:42 ` Peter Chubb
[not found] <20040102025509.91753.qmail@mail.com>
2004-01-02 13:01 ` [PATCH] laptop-mode-2.6.0, " Bart Samwel
2004-01-02 21:05 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040104103119.GB3418@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=bart@samwel.tk \
--cc=hugang@soulinfo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mrbk@gnarf.org \
--cc=peter@chubb.wattle.id.au \
--cc=smackinlay@mail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.