From: Andrew Morton <akpm@osdl.org>
To: Andrey Borzenkov <arvidjaar@mail.ru>
Cc: linux-kernel@vger.kernel.org, proski@gnu.org, kpfleming@cox.net
Subject: Re: [PATCH]: Fw: [Bugme-new] [Bug 1242] New: devfs oops with SMP kernel (not in UP mode)
Date: Sun, 4 Jan 2004 13:48:44 -0800 [thread overview]
Message-ID: <20040104134844.1aa69452.akpm@osdl.org> (raw)
In-Reply-To: <200401041932.40960.arvidjaar@mail.ru>
Andrey Borzenkov <arvidjaar@mail.ru> wrote:
>
> On Tuesday 16 September 2003 08:27, Andrew Morton wrote:
> > Andrey,
> >
> > didn't we fix this?
> >
> >
>
> Sorry for delay. Oops is due to concurrent d_instantiate on the same dentry;
> the bug was unfortunately quite ugly to fix inside devfs itself.
Andrey, thanks for working on this. It is good to have a go-to guy for
devfs problems. They all seem to be nasty nowadays.
> The attached patch makes sure d_revalidate is always called under parent i_sem
> allowing it to drop and reacquire semaphore before going to wait. It provides
> both mutual exclusion with devfs_lookup and between d_revalidate, fixing
Alas, people will have a heart-attack over the fs/namei.c changes. Is it
not possible to add an additional semaphore into devfs to provide this
exclusion? Are there any alternatives you can think of?
next prev parent reply other threads:[~2004-01-04 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030915212755.5017acc7.akpm@osdl.org>
2004-01-04 16:32 ` [PATCH]: Fw: [Bugme-new] [Bug 1242] New: devfs oops with SMP kernel (not in UP mode) Andrey Borzenkov
2004-01-04 16:49 ` Andrey Borzenkov
2004-01-04 21:48 ` Andrew Morton [this message]
2004-01-13 8:33 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040104134844.1aa69452.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=arvidjaar@mail.ru \
--cc=kpfleming@cox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.