From: Arjan van de Ven <arjanv@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: torvalds@osdl.org, akpm@osdl.org, davej@redhat.com
Subject: 2.6.1-rc1 arch/i386/kernel/setup.c wrong parameter order to request resources ?
Date: Sun, 4 Jan 2004 16:39:28 +0100 [thread overview]
Message-ID: <20040104153928.GB2416@devserv.devel.redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
Hi,
in setup.c the kernel tries to reserve ram resources for system ram etc
etc. However it seems it's done with the parameters to request_resource in
the wrong order (it certainly is opposite order from other neighboring
code). Can someone confirm I'm not overlooking something?
Greetings,
Arjan van de Ven
--- linux-2.6.0/arch/i386/kernel/setup.c~ 2004-01-04 16:37:34.622450000 +0100
+++ linux-2.6.0/arch/i386/kernel/setup.c 2004-01-04 16:37:34.622450000 +0100
@@ -834,8 +834,8 @@
* so we try it repeatedly and let the resource manager
* test it.
*/
- request_resource(res, &code_resource);
- request_resource(res, &data_resource);
+ request_resource(&code_resource, res);
+ request_resource(&data_resource, res);
}
}
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next reply other threads:[~2004-01-04 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-04 15:39 Arjan van de Ven [this message]
[not found] ` <Pine.LNX.4.58.0401041305440.2162@home.osdl.org>
2004-01-04 22:00 ` 2.6.1-rc1 arch/i386/kernel/setup.c wrong parameter order to request resources ? Arjan van de Ven
2004-03-29 15:43 ` Arjan van de Ven
-- strict thread matches above, loose matches on Subject: below --
2004-03-29 15:42 Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040104153928.GB2416@devserv.devel.redhat.com \
--to=arjanv@redhat.com \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.