From: Vojtech Pavlik <vojtech@suse.cz>
To: Andi Kleen <ak@muc.de>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] Remove Intel check in i386 HPET code
Date: Sun, 4 Jan 2004 22:56:21 +0100 [thread overview]
Message-ID: <20040104215621.GC14982@ucw.cz> (raw)
In-Reply-To: <20040104131350.GA21508@averell>
On Sun, Jan 04, 2004 at 02:13:50PM +0100, Andi Kleen wrote:
>
> The i386 HPET time setup code would explicitely check for the Intel
> vendor ID. That is bogus because other chipset vendors (like AMD)
> are implementing HPET too.
>
> Remove this check.
You can also remove the HPET_ID_VENDOR_8086 definition.
>
> -Andi
>
> diff -u linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c~ linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c
> --- linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c~ 2004-01-04 14:10:59.000000000 +0100
> +++ linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c 2004-01-04 14:10:59.000000000 +0100
> @@ -91,10 +91,6 @@
> !(id & HPET_ID_LEGSUP))
> return -1;
>
> - if (((id & HPET_ID_VENDOR) >> HPET_ID_VENDOR_SHIFT) !=
> - HPET_ID_VENDOR_8086)
> - return -1;
> -
> hpet_period = hpet_readl(HPET_PERIOD);
> if ((hpet_period < HPET_MIN_PERIOD) || (hpet_period > HPET_MAX_PERIOD))
> return -1;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2004-01-04 21:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-04 13:13 [PATCH] Remove Intel check in i386 HPET code Andi Kleen
2004-01-04 21:56 ` Vojtech Pavlik [this message]
2004-03-29 15:43 ` Vojtech Pavlik
-- strict thread matches above, loose matches on Subject: below --
2004-03-29 15:42 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040104215621.GC14982@ucw.cz \
--to=vojtech@suse.cz \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.