Re: [uml-devel] [UML combo patch] uml-combo-2.6.0-A7

[Ingo Molnar <mingo@elte.hu>]

* BlaisorBlade <blaisorblade_spam@yahoo.it> wrote:

> > plus fixed a bug in
> > the __do_mmap_pgoff() change that caused host kernel bootup hangs.
> 
> Yes, I did experience problems with my guest kernel (and today I
> tracked it down to the E* patches), but I didn't know what it is...
> Aargh! A missing return! Ok, I'm too foolish. Thanks for finding it!
> (But why the hell GCC 3.2.2 doesn't warn about it?)

yeah, interesting question. I tried a (very) fresh gcc snapshot too and
it doesnt warn either. Ironically, the only compiler that warned about
this was gcc296. (hah!) I filed a gcc bugreport.

> Two questions:
> 1) I've added the G-03(this fixes the empty /proc/kallsyms issue), H-03 and 
> H-04(for Makefiles cleanups) patches. Would you try them?

i'll try these too. Your bugfixes/collections are now perfectly fine for
2.6.0 UML experimentation so i'll use them instead of spinning my own
ones. (your ones are also better split up.)

> 2)Have you given a look to the mm/memory.c change (what I'd split into
> A-04)?  Do you think that change can be safe even for the host kernel?

tricky stuff - hand-building vmas is fragile like hell, and the vsyscall
stuff is far from simple too. What is the main purpose of your change?

	Ingo


-------------------------------------------------------
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills.  Sign up for IBM's
Free Linux Tutorials.  Learn everything from the bash shell to sys admin.
Click now! http://ads.osdn.com/?ad_id=1278&alloc_id=3371&op=click
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel