Re: [PATCH] Mark SIOCSIFNAME as compatible ioctl

[Andi Kleen <ak@suse.de>]

On Fri, 9 Jan 2004 02:04:56 -0800
"David S. Miller" <davem@redhat.com> wrote:

> On Thu, 8 Jan 2004 08:04:13 +0100
> Andi Kleen <ak@muc.de> wrote:
> 
> > Mark SIOCSIFNAME as an ioctl that doesn't need 32bit conversion.
> > 
> > Fixes nameif as 32bit executable.
> 
> How can we mark it compatible?  It needs the stuff dev_ifname32() in
> fs/compat_ioctl.c does for SIOCGIFNAME doesn't it?

It takes two strings. This should be compatible:

struct ifreq 
{
        union
        {
                char    ifrn_name[IFNAMSIZ];            /* if name, e.g. "en0" */
/
        } ifr_ifrn;
	 union {     
		...
                char    ifru_newname[IFNAMSIZ]; 
		...
        } ifr_ifru;
}; 

-Andi

P.S.: Maybe it would be time update the "en0" comment in if.h too ;-) I bet that comes from
VAX/BSD.