From: "Randy.Dunlap" <rddunlap@osdl.org>
To: linux-scsi@vger.kernel.org
Cc: jejb <james.bottomley@steeleye.com>
Subject: [PATCH] inia100.c: pointer used before being set
Date: Mon, 12 Jan 2004 21:07:54 -0800 [thread overview]
Message-ID: <20040112210754.582573ad.rddunlap@osdl.org> (raw)
drivers/scsi/inia100.c:421: warning: `pHCB' might be used uninitialized in this function
I see a problem there, patch is below. Warning is still there, however,
so this doesn't fix the warning, just fixes a real bug.
changelog: use local <port> since pHCB is not set yet;
product_versions: Linux 2.6.1
Please apply.
diffstat:=
diff -Naurp ./drivers/scsi/inia100.c~inia_warn ./drivers/scsi/inia100.c
--- ./drivers/scsi/inia100.c~inia_warn 2004-01-08 22:59:19.000000000 -0800
+++ ./drivers/scsi/inia100.c 2004-01-12 21:01:49.000000000 -0800
@@ -434,9 +434,9 @@ static int __devinit inia100_probe_one(s
}
port = pci_resource_start(pdev, 0);
- if (!request_region(pHCB->HCS_Base, 256, "inia100")) {
+ if (!request_region(port, 256, "inia100")) {
printk(KERN_WARNING "inia100: io port 0x%x, is busy.\n",
- pHCB->HCS_Base);
+ port);
goto out_disable_device; /* XXX: undo init_orchid() ?? */
}
--
~Randy
next reply other threads:[~2004-01-13 5:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-13 5:07 Randy.Dunlap [this message]
2004-01-13 5:17 ` [PATCH] inia100.c: pointer used before being set James Bottomley
2004-01-13 5:30 ` Randy.Dunlap
2004-01-13 15:07 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040112210754.582573ad.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=james.bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.