From: "Angelo Dell'Aera" <buffer@sniffo.org>
To: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
Cc: bunk@fs.tum.de, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fix a drivers/char/isicom.c compile warning
Date: Tue, 13 Jan 2004 12:45:49 +0100 [thread overview]
Message-ID: <20040113124549.229429b3.buffer@sniffo.org> (raw)
In-Reply-To: <20040113003828.GO18853@conectiva.com.br>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Mon, 12 Jan 2004 22:38:28 -0200
Arnaldo Carvalho de Melo <acme@conectiva.com.br> wrote:
>> I thought about it, but I wasn't sure whether changing a driver to be
>> more readable in _one_ place and making the code there different from
>> the coding style used in the rest of the driver is really an
>> improvement (and no, I don't want to clean the whole driver...)?
>
>Humm, IMHO it is better to get it with mixed style as long as the changes that
>"break" the style are for the correct style, but this, of course, for purely
>unmaintained stuff, like... isicom.c :-) For maintained stuff it becomes a
>pain in the ass for the maintainer, that should try to follow CodingStyle, but
>as we know, not always do.
I started cleaning isicom.c in such a way as to be more "CodingStyle
compliant" but it's a hard pain... the fix from Adrian is still in.
Hope to release it in a reasonable time.
Regards.
- --
Angelo Dell'Aera 'buffer'
Antifork Research, Inc. http://buffer.antifork.org
PGP information in e-mail header
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFAA9ptpONIzxnBXKIRAhlqAJ9jefAfKxXeLJYb0SCpqBp8EGfN0QCfdvuo
ToB15Ba8cV73AMOpbcjAe4I=
=fXgy
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2004-01-13 11:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-13 0:00 [2.6 patch] fix a drivers/char/isicom.c compile warning Adrian Bunk
2004-01-13 0:17 ` Arnaldo Carvalho de Melo
2004-01-13 0:23 ` Adrian Bunk
2004-01-13 0:38 ` Arnaldo Carvalho de Melo
2004-01-13 11:45 ` Angelo Dell'Aera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040113124549.229429b3.buffer@sniffo.org \
--to=buffer@sniffo.org \
--cc=acme@conectiva.com.br \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.