From: Russell King <rmk+lkml@arm.linux.org.uk>
To: jt@hpl.hp.com
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PROBLEM] ircomm ioctls
Date: Tue, 13 Jan 2004 18:29:55 +0000 [thread overview]
Message-ID: <20040113182955.F7256@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20040113181034.GA9960@bougret.hpl.hp.com>; from jt@bougret.hpl.hp.com on Tue, Jan 13, 2004 at 10:10:34AM -0800
On Tue, Jan 13, 2004 at 10:10:34AM -0800, Jean Tourrilhes wrote:
> Russell King wrote :
> > On Tue, Jan 13, 2004 at 12:00:15PM +0100, Jozef Vesely wrote:
> > > I am gettig this error (while connecting to my mobile phone):
> > > ------
> > > # gsmctl -d /dev/ircomm0 ALL
> > > gsmctl[ERROR]: clearing DTR failed (errno: 22/Invalid argument)
> > > ------
> >
> > ircomm needs updating to use the tiocmset/tiocmget driver calls. Could
> > you see if the following patch solves your problem please?
>
> Good catch. Is there any other API changes worth looking into ?
>
> By the way, I would rather keep the function
> ircomm_tty_tiocmget() and ircomm_tty_tiocmset() in ircomm_tty_ioctl.c,
> because ircomm_tty.c is already big and messy.
> Check the patch below (quickly tested).
I think this patch is missing some of the error checking (TTY_IO_ERROR)
which I included in my later patch.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/
2.6 Serial core
next prev parent reply other threads:[~2004-01-13 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-13 18:10 Re: [PROBLEM] ircomm ioctls Jean Tourrilhes
2004-01-13 18:29 ` Russell King [this message]
2004-01-13 19:08 ` Jean Tourrilhes
2004-01-14 19:38 ` Jean Tourrilhes
2004-01-14 20:24 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040113182955.F7256@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=jt@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.