All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Ben Greear <greearb@candelatech.com>
Cc: shemminger@osdl.org, netdev@oss.sgi.com
Subject: Re: [PATCH] support for large number of network devices.
Date: Tue, 13 Jan 2004 23:18:25 -0800	[thread overview]
Message-ID: <20040113231825.700e534f.davem@redhat.com> (raw)
In-Reply-To: <4004A194.3030602@candelatech.com>

On Tue, 13 Jan 2004 17:55:32 -0800
Ben Greear <greearb@candelatech.com> wrote:

> Stephen Hemminger wrote:
> > I have a patch for name hashing, but don't know if it's needed.
> > Even without it I can add 9 thousand bridge entries,
> > and each one takes longer to start the command than add the entry now. 
> 
> Check out the af_packet code.  At least some branches do a
> device lookup by name for each transmitted packet.  One
> method is:  packet_sendmsg_spkt
> 
> packet_sendmsg gets by index, which could also be hashed...
> 
> At one time ifconfig -a was almost un-usable with large numbers
> of devices, but I think it has been improved.  I haven't tried on
> large numbers of devices lately...

I found some other fast-path'ish cases of dev_get_by_name(), one of which
is atalk_rcv()'s handling of IP over DDP packets.

I didn't even search around for __dev_get() and dev_get_by_index() cases.
There are probably some more there.

Therefore, I think it's wise to just do this right from the start and use a hash.
Stephen can you test up and submit the netdev name hash patch you have?

  reply	other threads:[~2004-01-14  7:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-13 23:46 [PATCH] support for large number of network devices Stephen Hemminger
2004-01-13 23:59 ` David S. Miller
2004-01-14  0:13   ` Stephen Hemminger
2004-01-14  7:13     ` Matt Mackall
2004-01-14 19:37       ` Stephen Hemminger
2004-01-14 19:51         ` Matt Mackall
2004-01-14 20:11         ` David S. Miller
2004-01-15  0:24           ` Stephen Hemminger
2004-01-15  8:46             ` David S. Miller
2004-01-15 17:52               ` Stephen Hemminger
2004-01-15 19:40                 ` David S. Miller
2004-01-14  0:23 ` Ben Greear
2004-01-14  0:38   ` Stephen Hemminger
2004-01-14  1:55     ` Ben Greear
2004-01-14  7:18       ` David S. Miller [this message]
2004-01-14  7:54         ` Ben Greear
  -- strict thread matches above, loose matches on Subject: below --
2004-01-14 21:39 Jean Tourrilhes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040113231825.700e534f.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=greearb@candelatech.com \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.