From: Matt Mackall <mpm@selenic.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Tom Rini <trini@kernel.crashing.org>,
linux-kernel@vger.kernel.org, zaitcev@redhat.com
Subject: Re: [patch] arch-specific cond_syscall usage issues
Date: Wed, 14 Jan 2004 13:47:06 -0600 [thread overview]
Message-ID: <20040114194706.GI28521@waste.org> (raw)
In-Reply-To: <20040114113107.786c237a.akpm@osdl.org>
On Wed, Jan 14, 2004 at 11:31:07AM -0800, Andrew Morton wrote:
> Tom Rini <trini@kernel.crashing.org> wrote:
> >
> > As has been previously noted, the cond_syscall is only ever cared about
> > on PPC when you try for !PCI. And this only happens realistically now,
> > on MPC8xx (it's usually present on IBM 4xx, and lets ignore APUS).
> > MPC8xx support has been broken for a while, but hopefully will get fixed
> > 'soon'.
> >
> > So can we please move this cond_syscall into kernel/sys.c ?
>
> Spose so. Are we sure it shouldn't be inside soem ppc-specfic ifdef?
Probably not worth the trouble as it's a weak symbol - it can't
interfere with anything. In the unlikely case that some other arch
intends to define it and fails to, well, they'll get sys_ni_syscall
instead. By that logic, I've done the same with some of the stuff I've
made conditional for x86, like sys_vm86 and the like.
--
Matt Mackall : http://www.selenic.com : Linux development and consulting
next prev parent reply other threads:[~2004-01-14 19:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-10 3:29 [patch] arch-specific cond_syscall usage issues Matt Mackall
2004-01-10 3:37 ` Andrew Morton
2004-01-10 3:53 ` Matt Mackall
2004-01-10 5:21 ` Pete Zaitcev
2004-01-10 6:03 ` Matt Mackall
2004-01-14 16:13 ` Tom Rini
2004-01-14 19:31 ` Andrew Morton
2004-01-14 19:47 ` Matt Mackall [this message]
2004-01-14 19:49 ` Tom Rini
2004-04-23 19:14 ` [PATCH 2.6] include/asm-ppc/dma-mapping.h: dma_unmap_page() Arthur Othieno
2004-04-23 23:50 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040114194706.GI28521@waste.org \
--to=mpm@selenic.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trini@kernel.crashing.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.