From: Christoph Hellwig <hch@lst.de>
To: Yoichi Yuasa <yuasa@hh.iij4u.or.jp>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips <linux-mips@linux-mips.org>
Subject: Re: [PATCH][2.6] Update NEC VRC4171 PCMCIA driver
Date: Fri, 16 Jan 2004 13:33:52 +0100 [thread overview]
Message-ID: <20040116123352.GA13006@lst.de> (raw)
In-Reply-To: <20040116083821.6b65c69f.yuasa@hh.iij4u.or.jp>
On Fri, Jan 16, 2004 at 08:38:21AM +0900, Yoichi Yuasa wrote:
> +static int pccard_register_callback(unsigned int slot,
> + void (*handler)(void *, unsigned int),
> + void *info)
> +{
> + vrc4171_socket_t *socket;
> +
> + if (slot >= CARD_MAX_SLOTS)
> + return -EINVAL;
> +
> + socket = &vrc4171_sockets[slot];
> +
> + socket->handler = handler;
> + socket->info = info;
> +
> + if (handler)
> + MOD_INC_USE_COUNT;
> + else
> + MOD_DEC_USE_COUNT;
> +
> + return 0;
> +}
This is most certainly wrong. Module refcounting handling has moved one
layer up in 2.6.
next prev parent reply other threads:[~2004-01-16 12:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-15 23:38 [PATCH][2.6] Update NEC VRC4171 PCMCIA driver Yoichi Yuasa
2004-01-16 12:33 ` Christoph Hellwig [this message]
2004-01-18 2:53 ` Yoichi Yuasa
2004-01-19 12:58 ` Ralf Baechle
-- strict thread matches above, loose matches on Subject: below --
2004-01-27 17:03 Yoichi Yuasa
2004-02-21 15:29 Yoichi Yuasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040116123352.GA13006@lst.de \
--to=hch@lst.de \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=yuasa@hh.iij4u.or.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.