From: Christoph Hellwig <hch@infradead.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Amit S. Kale" <amitkale@emsyssoft.com>,
kgdb-bugreport@lists.sourceforge.net,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: KGDB 2.0.3 with fixes and development in ethernet interface
Date: Fri, 16 Jan 2004 14:07:28 +0000 [thread overview]
Message-ID: <20040116140728.B24102@infradead.org> (raw)
In-Reply-To: <20040116125806.GA7409@elf.ucw.cz>; from pavel@ucw.cz on Fri, Jan 16, 2004 at 01:58:06PM +0100
On Fri, Jan 16, 2004 at 01:58:06PM +0100, Pavel Machek wrote:
> ++int kgdbeth_thread(void *data)
> ++{
> ++ struct net_device *ndev = (struct net_device *)data;
> ++ daemonize("kgdbeth");
> ++ while (!ndev->ip_ptr) {
> ++ schedule();
> ++ }
> ++ debugger_entry();
> ++ return 0;
>
> Don't you need some locking around ndev->ip_ptr? [Okay, it probably
> only matters on SMP, so it is not causing your problems..]
Not to mention it should use a proper wait_event instead of this
really stupid loop.
next prev parent reply other threads:[~2004-01-16 14:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-16 12:29 KGDB 2.0.3 with fixes and development in ethernet interface Amit S. Kale
2004-01-16 12:58 ` Pavel Machek
2004-01-16 14:07 ` Christoph Hellwig [this message]
2004-01-16 14:24 ` Amit S. Kale
2004-01-16 14:17 ` Amit S. Kale
2004-01-16 14:45 ` Pavel Machek
2004-01-16 13:05 ` [discuss] " Andi Kleen
2004-01-16 14:21 ` Amit S. Kale
2004-01-16 14:45 ` Pavel Machek
2004-01-16 15:12 ` Amit S. Kale
2004-01-16 14:47 ` Pavel Machek
2004-01-16 15:15 ` Amit S. Kale
2004-01-16 15:52 ` Pavel Machek
2004-01-17 6:27 ` KGDB documentation [Re: [discuss] KGDB 2.0.3 with fixes and development in ethernet interface] Amit S. Kale
2004-01-17 9:00 ` George Anzinger
2004-01-16 18:39 ` [discuss] KGDB 2.0.3 with fixes and development in ethernet interface Matt Mackall
2004-01-16 16:13 ` Pavel Machek
2004-01-16 20:48 ` George Anzinger
2004-01-16 21:51 ` Pavel Machek
2004-01-17 1:23 ` George Anzinger
2004-01-17 9:29 ` Amit S. Kale
2004-01-17 19:54 ` George Anzinger
2004-01-21 13:46 ` Amit S. Kale
2004-01-21 18:39 ` Daniel Jacobowitz
2004-01-21 23:14 ` George Anzinger
2004-01-22 5:49 ` Amit S. Kale
2004-01-22 20:33 ` Daniel Jacobowitz
2004-01-21 23:00 ` George Anzinger
2004-01-22 5:09 ` Amit S. Kale
2004-01-22 17:20 ` Tom Rini
2004-01-22 22:54 ` George Anzinger
2004-01-22 22:57 ` Daniel Jacobowitz
2004-01-23 19:10 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040116140728.B24102@infradead.org \
--to=hch@infradead.org \
--cc=amitkale@emsyssoft.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.