From: Martin Hicks <mort@bork.org>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Fix error path when adding sysfs attributes
Date: Fri, 16 Jan 2004 14:33:41 -0500 [thread overview]
Message-ID: <20040116193341.GU27591@localhost> (raw)
In-Reply-To: <20040116192801.GT27591@localhost>
On Fri, Jan 16, 2004 at 02:28:01PM -0500, Martin Hicks wrote:
>
>
> @@ -380,11 +382,14 @@
> scsi_sysfs_sdev_attrs[i])) {
> error = device_create_file(&sdev->sdev_gendev,
> scsi_sysfs_sdev_attrs[i]);
> - if (error)
> + if (error) {
> scsi_remove_device(sdev);
> + goto out;
> + }
> }
> }
>
> + out:
This is tabbed stupidly. Sorry about that.
mh
--
Martin Hicks || mort@bork.org || PGP/GnuPG: 0x4C7F2BEE
next prev parent reply other threads:[~2004-01-16 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-16 19:28 [PATCH] Fix error path when adding sysfs attributes Martin Hicks
2004-01-16 19:33 ` Martin Hicks [this message]
2004-01-16 19:48 ` Mike Anderson
2004-01-16 20:33 ` Martin Hicks
2004-01-16 20:52 ` Martin Hicks
2004-01-16 21:29 ` Mike Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040116193341.GU27591@localhost \
--to=mort@bork.org \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.