From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] [patch 2.6.1] net/core/dev.c -comparison
Date: Sat, 17 Jan 2004 14:20:15 +0000 [thread overview]
Message-ID: <200401171520.15308.domen@coderock.org> (raw)
Hi.
Get rid of one comparison, improve readability.
--- linux-2.6.0-test11-small/net/core/dev.c 2003-11-29 21:47:03.000000000 +0100
+++ linux-2.6.0-test11-athlon/net/core/dev.c 2003-12-13 17:27:37.000000000 +0100
@@ -1872,9 +1872,9 @@ void dev_seq_stop(struct seq_file *seq,
static void dev_seq_printf_stats(struct seq_file *seq, struct net_device *dev)
{
- struct net_device_stats *stats = dev->get_stats ? dev->get_stats(dev) :
- NULL;
- if (stats)
+ if (dev->get_stats) {
+ struct net_device_stats *stats = dev->get_stats(dev);
+
seq_printf(seq, "%6s:%8lu %7lu %4lu %4lu %4lu %5lu %10lu %9lu "
"%8lu %7lu %4lu %4lu %4lu %5lu %7lu %10lu\n",
dev->name, stats->rx_bytes, stats->rx_packets,
@@ -1892,6 +1892,7 @@ static void dev_seq_printf_stats(struct
stats->tx_window_errors +
stats->tx_heartbeat_errors,
stats->tx_compressed);
+ }
else
seq_printf(seq, "%6s: No statistics available.\n", dev->name);
}
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
reply other threads:[~2004-01-17 14:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200401171520.15308.domen@coderock.org \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.