From: Dimitri Torfs <dimitri@sonycom.com>
To: linux-mips@linux-mips.org
Subject: Re: VR4131 - MQ1132 - UPD63335
Date: Sun, 18 Jan 2004 10:23:19 +0100 [thread overview]
Message-ID: <20040118092318.GA22052@sonycom.com> (raw)
In-Reply-To: <20040117125142.GX14285@lug-owl.de>
On Sat, Jan 17, 2004 at 01:51:42PM +0100, Jan-Benedict Glaw wrote:
> On Sat, 2004-01-17 13:20:22 +0100, Ralf Baechle <ralf@linux-mips.org>
> wrote in message <20040117122022.GD5288@linux-mips.org>:
> > #define FOO_BASE 0x12340000UL /* physical address */
> ^^^^^^^^^^
> > #define FOO_SIZE 0x00001000UL
> >
> > base = ioremap(0x1234, FOO_SIZE);
> ^^^^^^
> Not FOO_BASE?
>
And it's better to use writel/readl and friends on thingies returned by
ioremap:
struct foo_regs* foo = ioremap(FOO_BASE, FOO_SIZE);
...
writel(42, &foo->blinkenlight);
Dimitri
--
Dimitri Torfs | NSCE
dimitri@sonycom.com | The Corporate Village
tel: +32 2 7008541 | Da Vincilaan 7 - D1
fax: +32 2 7008622 | B-1935 Zaventem - Belgium
prev parent reply other threads:[~2004-01-18 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-16 7:32 VR4131 - MQ1132 - UPD63335 Suresh. R
2004-01-16 9:49 ` Geert Uytterhoeven
2004-01-16 9:49 ` Geert Uytterhoeven
2004-01-16 10:09 ` Kevin D. Kissell
2004-01-16 10:09 ` Kevin D. Kissell
2004-01-17 12:20 ` Ralf Baechle
2004-01-17 12:51 ` Jan-Benedict Glaw
2004-01-18 9:23 ` Dimitri Torfs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040118092318.GA22052@sonycom.com \
--to=dimitri@sonycom.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.