From: Adrian Bunk <bunk@fs.tum.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [rfc] a lot of unused CONFIG_*
Date: Sun, 18 Jan 2004 12:53:22 +0000 [thread overview]
Message-ID: <20040118125322.GP12027@fs.tum.de> (raw)
In-Reply-To: <200401171704.40353.domen@coderock.org>
On Sat, Jan 17, 2004 at 05:04:40PM +0100, Domen Puncer wrote:
> Hi.
>
> # wc -l CONFIG_defined_but_not_used CONFIG_not_defined_but_used
> 116 CONFIG_defined_but_not_used
> 635 CONFIG_not_defined_but_used
>
> This is a lot!
>
> I didn't strip out "*_MODULE" (don't know if they're automagicaly
> generated and it doesn't make much difference).
These symbols are automatically generated when configuring a variable to
be modular.
> So... am I wrong about my script, or do we have A LOT of work to do?
>...
It's sometimes used and 100% correct to define options that are only
used in the Kconfig file they are defined in.
Examples are some cpu variables in from arch/i386/Kconfig .
It often occurs that a variable is only used in a Makefile to select a
subdirectory (e.g. CONFIG_E1000), but your scripts didn't count this
use.
Not all Kconfig files are named Kconfig, Kconfig\* is a better
expression.
Not all things your script output are really bugs, e.g. there might be
an #ifdef CONFIG_FOO in the code without CONFIG_FOO being defined
anywhere, but it's defined in another tree (e.g. an architecture tree)
that will be resynced with the kernel soon.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-01-18 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-17 16:04 [Kernel-janitors] [rfc] a lot of unused CONFIG_* Domen Puncer
2004-01-18 12:53 ` Adrian Bunk [this message]
2004-01-19 18:22 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040118125322.GP12027@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.