From: Rusty Russell <rusty@rustcorp.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: jamagallon@able.es, linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: 2.6.1-mm4
Date: Mon, 19 Jan 2004 22:42:19 +1100 [thread overview]
Message-ID: <20040119224219.65991501.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20040118001708.09291455.akpm@osdl.org>
On Sun, 18 Jan 2004 00:17:08 -0800
Andrew Morton <akpm@osdl.org> wrote:
> Presumably, recent gcc's remove the variable altogether and just expand the
> constant inline. When the central module code checks for the parameter's
> existence in the module's symbol table it errors out.
MODULE_PARM considered harmful.
Unfortunately, there's no easy way of fixing this, since MODULE_PARM()
is often used on variables which aren't declared yet 8(. (I tried this
in an early patch).
Migrating to module_param() is the Right Thing here IMHO, which actually
takes the damn address,
Rusty.
--
there are those who do and those who hang on and you don't see too
many doers quoting their contemporaries. -- Larry McVoy
next prev parent reply other threads:[~2004-01-19 12:01 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-16 6:59 2.6.1-mm4 Andrew Morton
2004-01-16 6:59 ` 2.6.1-mm4 Andrew Morton
2004-01-16 9:34 ` 2.6.1-mm4 Prakash K. Cheemplavam
2004-01-16 9:34 ` 2.6.1-mm4 Prakash K. Cheemplavam
2004-01-21 18:46 ` 2.6.1-mm4 Prakash K. Cheemplavam
2004-01-21 18:46 ` 2.6.1-mm4 Prakash K. Cheemplavam
2004-01-21 19:20 ` 2.6.1-mm4 Valdis.Kletnieks
2004-02-11 22:22 ` 2.6.1-mm4 Prakash K. Cheemplavam
2004-02-12 5:52 ` 2.6.1-mm4 Valdis.Kletnieks
2004-02-12 7:30 ` 2.6.1-mm4 Prakash K. Cheemplavam
2004-02-12 8:46 ` 2.6.1-mm4 Valdis.Kletnieks
2004-02-12 13:15 ` 2.6.1-mm4 Prakash K. Cheemplavam
2004-02-12 16:11 ` 2.6.1-mm4 Prakash K. Cheemplavam
2004-01-16 13:45 ` 2.6.1-mm4 Ed Tomlinson
2004-01-16 13:45 ` 2.6.1-mm4 Ed Tomlinson
2004-01-16 17:32 ` 2.6.1-mm4 Thomas Schlichter
2004-01-16 14:49 ` 2.6.1-mm4 Fabian Fenaut
2004-01-16 14:49 ` 2.6.1-mm4 Fabian Fenaut
[not found] ` <200401161449.i0GEnoAv026627@fire-1.osdl.org>
2004-01-16 17:03 ` 2.6.1-mm4 Andrew Morton
2004-01-16 17:03 ` 2.6.1-mm4 Andrew Morton
2004-01-16 18:11 ` 2.6.1-mm4 Fabian Fenaut
2004-01-16 17:14 ` 2.6.1-mm4 (compile stats) John Cherry
2004-01-16 17:14 ` John Cherry
2004-01-16 17:37 ` 2.6.1-mm4 Thomas Schlichter
2004-01-16 17:58 ` 2.6.1-mm4 Thomas Schlichter
2004-01-16 18:17 ` Oops in register_proc_table (2.6.1-mm4) Thomas Schlichter
2004-01-17 20:11 ` Paul Misner
2004-01-17 1:31 ` 2.6.1-mm4 Greg Fitzgerald
2004-01-17 1:40 ` 2.6.1-mm4 Mike Fedyk
2004-01-17 2:07 ` 2.6.1-mm4 Greg Fitzgerald
2004-01-17 2:24 ` 2.6.1-mm4 Mike Fedyk
2004-01-17 4:05 ` 2.6.1-mm4 Dmitry Torokhov
2004-01-17 4:22 ` 2.6.1-mm4 Greg Fitzgerald
2004-01-17 2:22 ` 2.6.1-mm4 Adrian Bunk
2004-01-17 2:22 ` 2.6.1-mm4 Adrian Bunk
2004-01-18 0:12 ` 2.6.1-mm4 J.A. Magallon
2004-01-18 5:55 ` 2.6.1-mm4 Andrew Morton
2004-01-18 8:11 ` 2.6.1-mm4 J.A. Magallon
2004-01-18 8:17 ` 2.6.1-mm4 Andrew Morton
2004-01-19 11:42 ` Rusty Russell [this message]
2004-01-19 11:00 ` 2.6.1-mm4 same sound oops as mm3 Helge Hafting
2004-01-19 11:00 ` Helge Hafting
2004-01-19 11:46 ` 2.6.1-mm4 Luiz Fernando Capitulino
2004-01-19 11:46 ` 2.6.1-mm4 Luiz Fernando Capitulino
2004-01-20 0:26 ` 2.6.1-mm4 Thomas Molina
2004-01-20 0:26 ` 2.6.1-mm4 Thomas Molina
2004-01-20 0:57 ` 2.6.1-mm4 Andrew Morton
2004-01-20 0:57 ` 2.6.1-mm4 Andrew Morton
2004-01-20 2:13 ` 2.6.1-mm4 Thomas Molina
2004-01-20 2:13 ` 2.6.1-mm4 Thomas Molina
-- strict thread matches above, loose matches on Subject: below --
2004-01-17 13:13 2.6.1-mm4 Thomas Molina
2004-01-17 18:14 ` 2.6.1-mm4 Hugh Dickins
2004-01-17 18:52 ` 2.6.1-mm4 Andrew Morton
2004-01-19 7:16 ` 2.6.1-mm4 Rusty Russell
2004-01-19 11:29 ` 2.6.1-mm4 Rusty Russell
[not found] <20040115225948.6b994a48.akpm@osdl.org.suse.lists.linux.kernel>
[not found] ` <20040118001217.GE3125@werewolf.able.es.suse.lists.linux.kernel>
[not found] ` <20040117215535.0e4674b8.akpm@osdl.org.suse.lists.linux.kernel>
[not found] ` <20040118081128.GA3153@werewolf.able.es.suse.lists.linux.kernel>
[not found] ` <20040118001708.09291455.akpm@osdl.org.suse.lists.linux.kernel>
[not found] ` <20040119224219.65991501.rusty@rustcorp.com.au.suse.lists.linux.kernel>
2004-01-19 12:40 ` 2.6.1-mm4 Andi Kleen
2004-01-21 4:06 ` 2.6.1-mm4 Rusty Russell
2004-01-21 4:56 ` 2.6.1-mm4 Valdis.Kletnieks
2004-01-21 8:40 ` 2.6.1-mm4 Vojtech Pavlik
2004-01-21 12:27 ` 2.6.1-mm4 Andi Kleen
2004-01-21 12:34 ` 2.6.1-mm4 Vojtech Pavlik
2004-01-21 12:46 ` 2.6.1-mm4 Andi Kleen
2004-01-21 13:13 ` 2.6.1-mm4 Vojtech Pavlik
2004-01-22 1:31 ` 2.6.1-mm4 Rusty Russell
2004-01-21 12:53 ` 2.6.1-mm4 Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040119224219.65991501.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=jamagallon@able.es \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.