All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timmy Yee <shoujun@masterofpi.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] fix kmalloc() in aha1542.c
Date: Tue, 20 Jan 2004 15:33:10 +0000	[thread overview]
Message-ID: <20040120153310.GB3384@masterofpi.org> (raw)
In-Reply-To: <20040119034853.GA15426@masterofpi.org>

On Mon, Jan 19, 2004 at 01:37:15PM +0100, Daniele Bellucci wrote:
> 
> |-		SCpnt->host_scribble = (unsigned char *) kmalloc(512, GFP_DMA);
> |+		SCpnt->host_scribble = (unsigned char *) kmalloc(512, GFP_KERNEL | GFP_DMA);
> | 		sgpnt = (struct scatterlist *) SCpnt->request_buffer;
> | 		cptr = (struct chain *) SCpnt->host_scribble;
> 
> I didn't look to much at your patch but 
> because you are at it can you please audit that kmalloc too?

The address returned by kmalloc() seems to be checked three lines later.
Though it calls panic() if the address is NULL. I'm not sure if that's the
correct way to fail on an allocation.
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2004-01-20 15:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-19  3:48 [Kernel-janitors] [PATCH] fix kmalloc() in aha1542.c Timmy Yee
2004-01-19 12:37 ` Daniele Bellucci
2004-01-20 15:20 ` Timmy Yee
2004-01-20 15:33 ` Timmy Yee [this message]
2004-01-20 22:55 ` Randy.Dunlap
2004-01-20 23:07 ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040120153310.GB3384@masterofpi.org \
    --to=shoujun@masterofpi.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.