From: Christoph Hellwig <hch@infradead.org>
To: Patrick Gefre <pfg@sgi.com>
Cc: akpm@osdl.org, davidm@napali.hpl.hp.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6] Altix updates
Date: Tue, 20 Jan 2004 20:21:32 +0000 [thread overview]
Message-ID: <20040120202132.A20668@infradead.org> (raw)
In-Reply-To: <400D8BBF.7070005@sgi.com>; from pfg@sgi.com on Tue, Jan 20, 2004 at 02:12:47PM -0600
On Tue, Jan 20, 2004 at 02:12:47PM -0600, Patrick Gefre wrote:
> Guess I don't understand your point. Do you want us to create separate
> functions for soft-struct and bridge address
> and TIO and non-TIO - 4 functions for each register access, rather than 1 ?
The right fix would be to only have one, and that one would take the
bridge_t. If you really want to have one that takes the pcibr_soft, too
make it a small wrapper. But even that would be two and not four, where
do the other two come from?
next prev parent reply other threads:[~2004-01-20 20:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-15 21:54 [PATCH 2.6] Altix updates Pat Gefre
2004-01-16 2:34 ` Andrew Morton
2004-01-16 14:41 ` Christoph Hellwig
2004-01-20 17:50 ` Patrick Gefre
2004-01-20 18:08 ` Christoph Hellwig
2004-01-20 20:12 ` Patrick Gefre
2004-01-20 20:21 ` Christoph Hellwig [this message]
2004-01-20 22:23 ` Patrick Gefre
2004-01-20 23:34 ` Christoph Hellwig
2004-01-21 0:23 ` Patrick Gefre
2004-01-21 0:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040120202132.A20668@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=davidm@napali.hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pfg@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.