From: "Randy.Dunlap" <rddunlap@osdl.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mm/pdflush.c - handle kernel_thread failure
Date: Wed, 21 Jan 2004 18:36:29 +0000 [thread overview]
Message-ID: <20040121103629.59b8e95a.rddunlap@osdl.org> (raw)
In-Reply-To: <20040121183259.GA17474@eugeneteo.net>
On Thu, 22 Jan 2004 02:32:59 +0800 Eugene Teo <eugene.teo@eugeneteo.net> wrote:
| A similar patch is included in 2.6.1-kj1. I am resubmitting
| this with a couple of amendments - store the return value to
| pid_t type variable, and use C99 __func__ instead.
|
| diff -Naur -X /home/amnesia/w/dontdiff 2.6.2-rc1-orig/mm/pdflush.c 2.6.2-rc1-fix/mm/pdflush.c
| --- 2.6.2-rc1-orig/mm/pdflush.c 2004-01-22 02:19:29.000000000 +0800
| +++ 2.6.2-rc1-fix/mm/pdflush.c 2004-01-22 02:24:26.000000000 +0800
| @@ -207,7 +207,11 @@
|
| static void start_one_pdflush_thread(void)
| {
| - kernel_thread(pdflush, NULL, CLONE_KERNEL);
| + pid_t ret;
| +
| + ret = kernel_thread(pdflush, NULL, CLONE_KERNEL);
| + if (ret < 0)
| + printk("%s: unable to start kernel thread\n", __func__);
| }
|
| static int __init pdflush_init(void)
Nope. As Andrew pointed out to me:
"Nope, if we fail to start a thread here we'll just try again later.
There's no need to warn."
--
~Randy
kernel-janitors project: http://janitor.kernelnewbies.org/
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Kernel-janitor-discuss mailing list
Kernel-janitor-discuss@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kernel-janitor-discuss
next prev parent reply other threads:[~2004-01-21 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-21 18:32 [PATCH] mm/pdflush.c - handle kernel_thread failure Eugene Teo
2004-01-21 18:36 ` Randy.Dunlap [this message]
2004-01-21 18:47 ` Eugene Teo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040121103629.59b8e95a.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.