From: Rusty Russell <rusty@rustcorp.com.au>
To: Matt Mackall <mpm@selenic.com>
Cc: akpm@osdl.org, pavel@ucw.cz, linux-kernel@vger.kernel.org
Subject: Re: More cleanups for swsusp
Date: Thu, 22 Jan 2004 13:03:39 +1100 [thread overview]
Message-ID: <20040122130339.009eeb7d.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20040121183938.GE14797@waste.org>
On Wed, 21 Jan 2004 12:39:38 -0600
Matt Mackall <mpm@selenic.com> wrote:
> > > 3) BUG_ON(complex condition expression) is much less clear than:
> > >
> > > if (complex condition expression)
> > > BUG();
>
> Disagree. All BUG_ON() stuff should read like:
>
> /* check that impossible stuff didn't happen, move along, nothing to see */
> BUG_ON(...);
You can disagree all you like.
But Linus only allowed BUG_ON() because of the branch-prediction problem,
preferring explicit "if (x) BUG()". I happen to agree with him, especially
if x is a complex expression.
Rusty.
--
there are those who do and those who hang on and you don't see too
many doers quoting their contemporaries. -- Larry McVoy
prev parent reply other threads:[~2004-01-22 4:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-20 22:52 More cleanups for swsusp Pavel Machek
2004-01-20 23:13 ` Andrew Morton
2004-01-20 23:25 ` Pavel Machek
2004-01-21 5:10 ` Rusty Russell
2004-01-22 0:17 ` Pavel Machek
2004-01-21 5:14 ` Rusty Russell
2004-01-21 5:30 ` Andrew Morton
2004-01-21 18:39 ` Matt Mackall
2004-01-22 2:03 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040122130339.009eeb7d.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.