From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24)
	id 1Ak0Zw-0001F6-RR
	for qemu-devel@nongnu.org; Fri, 23 Jan 2004 07:38:28 -0500
Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24)
	id 1Ak0Ty-0000eq-KA
	for qemu-devel@nongnu.org; Fri, 23 Jan 2004 07:32:50 -0500
Received: from [195.184.98.160] (helo=virtualhost.dk)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.24) id 1Ak0Qz-0008T8-8H
	for qemu-devel@nongnu.org; Fri, 23 Jan 2004 07:29:13 -0500
Received: from brick.kernel.dk ([62.242.22.158] helo=wiggum.home.kernel.dk)
	by virtualhost.dk with esmtp (Exim 3.36 #1) id 1Ak0Qz-0006Ya-00
	for qemu-devel@nongnu.org; Fri, 23 Jan 2004 13:29:13 +0100
Received: from axboe by wiggum.home.kernel.dk with local (Exim 4.22)
	id 1Ak0Qw-00017n-AX
	for qemu-devel@nongnu.org; Fri, 23 Jan 2004 13:29:10 +0100
Date: Fri, 23 Jan 2004 13:29:10 +0100
From: Jens Axboe <axboe@suse.de>
Message-ID: <20040123122910.GA4143@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Subject: [Qemu-devel] ata bug
Reply-To: qemu-devel@nongnu.org
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <http://mail.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://mail.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hi,

Writing some openbios ide code made me find this bug in qemu - atapi
need only clear busy stat, that is correct, but ata should set seek stat
in addition to ready stat.

Index: ide.c
===================================================================
RCS file: /cvsroot/qemu/qemu/ide.c,v
retrieving revision 1.6
diff -u -r1.6 ide.c
--- ide.c	22 Jan 2004 23:52:27 -0000	1.6
+++ ide.c	23 Jan 2004 12:18:46 -0000
@@ -1284,7 +1284,7 @@
             if (s->is_cdrom)
                 s->status = 0x00; /* NOTE: READY is _not_ set */
             else
-                s->status = READY_STAT;
+                s->status = READY_STAT | SEEK_STAT;
             ide_set_signature(s);
         }
     }

-- 
Jens Axboe