All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Dike <jdike@addtoit.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: user-mode-linux-devel@lists.sourceforge.net
Subject: [uml-devel] Re: [patch] uml fixes, 2.6.1-mm5-A2
Date: Fri, 23 Jan 2004 08:56:47 -0500	[thread overview]
Message-ID: <20040123135647.GA6768@ccure.user-mode-linux.org> (raw)
In-Reply-To: <20040123093541.GA21763@elte.hu>

On Fri, Jan 23, 2004 at 10:35:41AM +0100, Ingo Molnar wrote:
> hm, there's this code in arch/um/sys-i386/bugs.c:arch_handle_signal():
> 
>         ip = UPT_IP(regs);
>         if((*((char *) ip) != 0x0f) || ((*((char *) (ip + 1)) & 0xf0) != 0x40))
>                 return(0);
> 
> we are running in the UML kernel context here. Is the dereferencing of
> IP safe? 

No, it's not.  There needs to be a copy_from_user in there.

				Jeff


-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

  reply	other threads:[~2004-01-23 13:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-20 19:17 [uml-devel] [patch] uml-fixes-2.6.1-mm5-A1 Ingo Molnar
2004-01-20 19:43 ` [uml-devel] [patch] uml-fixes2-2.6.1-mm5-A0 Ingo Molnar
2004-01-20 20:01   ` [uml-devel] [patch] uml-fixes2-2.6.1-mm5-A1 Ingo Molnar
2004-01-22 16:21     ` [uml-devel] [patch] uml fixes, 2.6.1-mm5-A2 Ingo Molnar
2004-01-22 18:42       ` Jeff Dike
2004-01-23  6:18       ` nsb034
2004-01-28  4:39         ` Jeff Dike
2004-01-23  9:35       ` [uml-devel] " Ingo Molnar
2004-01-23 13:56         ` Jeff Dike [this message]
2004-01-23 13:51           ` Ingo Molnar
2004-01-23 16:09             ` Jeff Dike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040123135647.GA6768@ccure.user-mode-linux.org \
    --to=jdike@addtoit.com \
    --cc=mingo@elte.hu \
    --cc=user-mode-linux-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.