From: Vojtech Pavlik <vojtech@suse.cz>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Manfred Spraul <manfred@colorfullife.com>,
Carl-Daniel Hailfinger <c-d.hailfinger.kernel.2004@gmx.net>,
linux-kernel@vger.kernel.org, Netdev <netdev@oss.sgi.com>
Subject: Re: [PATCH] [2.4] forcedeth network driver
Date: Sat, 24 Jan 2004 23:05:45 +0100 [thread overview]
Message-ID: <20040124220545.GA3246@ucw.cz> (raw)
In-Reply-To: <4012D3C6.1050805@pobox.com>
On Sat, Jan 24, 2004 at 03:21:26PM -0500, Jeff Garzik wrote:
> >>>+static int alloc_rx(struct net_device *dev)
> >>>+{
> >[snip]
> >>>+ return 0;
> >>>+}
> >>
> >>skb_reserve() seems to be missing
> >>
> >Do you have specs that show that all nForce versions support unaligned
> >buffers? skb_reserve is a performance feature, I don't want to add it
> >yet. Testing that it works is on our TODO list.
>
> hmmmm, is nForce ever found on non-x86 boxes? I would think that
> skb_reserve might be -required- for some platforms.
AMD64 and PPC64 as far as I know. But you may consider the first one
still a x86 box.
--
Vojtech Pavlik
SuSE Labs, SuSE CR
next prev parent reply other threads:[~2004-01-24 22:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-24 18:53 [PATCH] [2.4] forcedeth network driver Manfred Spraul
2004-01-24 20:21 ` Jeff Garzik
2004-01-24 21:55 ` Carl-Daniel Hailfinger
2004-01-24 23:57 ` Jeff Garzik
2004-01-24 22:05 ` Vojtech Pavlik [this message]
2004-01-24 22:33 ` Carl-Daniel Hailfinger
2004-01-24 22:46 ` Vojtech Pavlik
2004-01-24 23:11 ` Paul Mackerras
2004-01-27 13:30 ` Rask Ingemann Lambertsen
-- strict thread matches above, loose matches on Subject: below --
2004-02-05 0:52 Carl-Daniel Hailfinger
2004-02-05 9:45 ` Jeff Garzik
2004-01-24 17:11 Carl-Daniel Hailfinger
2004-01-24 17:58 ` Jeff Garzik
2004-01-24 21:24 ` Carl-Daniel Hailfinger
2004-01-25 0:01 ` Jeff Garzik
2004-01-24 18:59 ` Francois Romieu
2004-01-24 19:02 ` Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040124220545.GA3246@ucw.cz \
--to=vojtech@suse.cz \
--cc=c-d.hailfinger.kernel.2004@gmx.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.