From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Randy.Dunlap" Date: Mon, 26 Jan 2004 22:34:59 +0000 Subject: Re: [Kernel-janitors] [PATCH] drivers/ide/ide-tape.c - handle Message-Id: <20040126143459.2fdb4724.rddunlap@osdl.org> List-Id: References: <20040122040839.GA2456@eugeneteo.net> In-Reply-To: <20040122040839.GA2456@eugeneteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org On Thu, 22 Jan 2004 12:08:39 +0800 Eugene Teo wrote: | I have not compile nor test this patch. stage has to be checked for | null. No trailing spaces too :) | | 2902: static idetape_stage_t *__idetape_kmalloc_stage (..........) | [...] | 2909: if ((stage = (idetape_stage_t *) kmalloc (sizeof \ | (idetape_stage_t),GFP_KERNEL)) = NULL) | 2910: return NULL; | | diff -Naur -X /home/amnesia/w/dontdiff 2.6.2-rc1-orig/drivers/ide/ide-tape.c 2.6.2-rc1-fix/drivers/ide/ide-tape.c | --- 2.6.2-rc1-orig/drivers/ide/ide-tape.c 2004-01-22 02:19:18.000000000 +0800 | +++ 2.6.2-rc1-fix/drivers/ide/ide-tape.c 2004-01-22 12:01:56.000000000 +0800 | @@ -3619,6 +3619,8 @@ | printk(KERN_INFO "ide-tape: %s: reading back %d frames from the drive's internal buffer\n", tape->name, frames); | for (i = 0; i < frames; i++) { | stage = __idetape_kmalloc_stage(tape, 0, 0); | + if (!stage) | + return; | if (!first) | first = stage; | aux = stage->aux; | so... what makes it OK for void function "idetape_onstream_read_back_buffer" to just return at this point? It can't (or doesn't) return an error AFAICT, but the calling function expected certain work to be done... I guess that it could panic(), although I hate adding panics. -- ~Randy kernel-janitors project: http://janitor.kernelnewbies.org/ _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org http://lists.osdl.org/mailman/listinfo/kernel-janitors