All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: kai@germaschewski.name, sam@ravnborg.org
Cc: linux-kernel@vger.kernel.org, kbuild-devel@lists.sourceforge.net
Subject: [PATCH] fix menuconfig choice item help display
Date: Tue, 27 Jan 2004 09:55:24 -0700	[thread overview]
Message-ID: <200401270955.24371.bjorn.helgaas@hp.com> (raw)

This patch against 2.6.2-rc2 fixes menuconfig so it can display
help text for individual choice group config entries.

Previously it would only display the help text attached to the
"choice" item.  There was no way to display the help attached to
individual config entries inside the choice group.  Typically,
the "choice" item has no help text, and all the useful help is
attached to the individual entries, so this was a bit of a
problem.

===== scripts/kconfig/mconf.c 1.10 vs edited =====
--- 1.10/scripts/kconfig/mconf.c	Mon Jan 19 16:38:08 2004
+++ edited/scripts/kconfig/mconf.c	Tue Jan 27 09:44:30 2004
@@ -635,7 +635,9 @@
 			sym_set_tristate_value(menu->sym, yes);
 			return;
 		case 1:
-			show_help(menu);
+			if (sscanf(input_buf, "%p", &child) != 1)
+				break;
+			show_help(child);
 			break;
 		case 255:
 			return;
===== scripts/lxdialog/checklist.c 1.3 vs edited =====
--- 1.3/scripts/lxdialog/checklist.c	Tue Feb  5 00:39:14 2002
+++ edited/scripts/lxdialog/checklist.c	Tue Jan 27 09:35:44 2004
@@ -303,6 +303,9 @@
 	case 'h':
 	case '?':
 	    delwin (dialog);
+	    fprintf(stderr, "%s \"%s\"\n",
+		    items[(scroll + choice) * 3],
+		    items[(scroll + choice) * 3 + 1]);
 	    free (status);
 	    return 1;
 	case TAB:
@@ -318,7 +321,11 @@
 	case 's':
 	case ' ':
 	case '\n':
-	    if (!button) {
+	    if (button)
+		    fprintf(stderr, "%s \"%s\"\n",
+			    items[(scroll + choice) * 3],
+			    items[(scroll + choice) * 3 + 1]);
+	    else {
 		if (flag == FLAG_CHECK) {
 		    status[scroll + choice] = !status[scroll + choice];
 		    wmove (list, choice, check_x);


                 reply	other threads:[~2004-01-27 16:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200401270955.24371.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=kai@germaschewski.name \
    --cc=kbuild-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.